From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Vinod <vkoul@kernel.org>, Rohit Kumar <rohitkr@codeaurora.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, bgoswami@codeaurora.org,
linux-kernel@vger.kernel.org, plai@codeaurora.org,
tiwai@suse.com, lgirdwood@gmail.com, robh+dt@kernel.org,
broonie@kernel.org
Subject: Re: [PATCH] ASoC: qcom: add sdm845 sound card support
Date: Wed, 20 Jun 2018 10:53:01 +0100 [thread overview]
Message-ID: <53db13d7-b4bd-0e06-4110-ce75fd0bdd3c@linaro.org> (raw)
In-Reply-To: <20180620093106.GI13316@vkoul-mobl>
On 20/06/18 10:31, Vinod wrote:
>> Here clock will be enabled twice but disable will be called only once when
>> count = 0.
>>
>> This will make the clock always enabled. So, I think we should keep either
>> mutex lock or atomic variable to synchronize this.
> we are using DPCM here right?
We should probably model this clk as DAPM widget so we do not need to
handle this in machine code.
--srini
next prev parent reply other threads:[~2018-06-20 9:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 11:16 [PATCH] ASoC: qcom: add sdm845 sound card support Rohit kumar
2018-06-19 5:05 ` [alsa-devel] " Vinod
2018-06-19 13:50 ` Rohit Kumar
2018-06-19 16:22 ` Vinod
2018-06-20 7:37 ` Rohit Kumar
2018-06-20 9:31 ` Vinod
2018-06-20 9:53 ` Srinivas Kandagatla [this message]
2018-06-20 10:28 ` Vinod
2018-06-19 8:46 ` Srinivas Kandagatla
2018-06-19 13:58 ` [alsa-devel] " Rohit Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53db13d7-b4bd-0e06-4110-ce75fd0bdd3c@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).