From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre-Louis Bossart Subject: Re: [asoc:for-5.2 248/316] sound/soc/sof/core.c:279: undefined reference to `sof_nocodec_setup' Date: Tue, 7 May 2019 10:57:34 -0500 Message-ID: <53f05fee-48d0-3ba3-56d3-2624f20e9f1e@linux.intel.com> References: <201905072128.M0UIELnr%lkp@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 333D7F89674 for ; Tue, 7 May 2019 18:12:48 +0200 (CEST) In-Reply-To: <201905072128.M0UIELnr%lkp@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: kbuild test robot , Liam Girdwood Cc: Takashi Iwai , alsa-devel@alsa-project.org, Mark Brown , kbuild-all@01.org List-Id: alsa-devel@alsa-project.org On 5/7/19 8:28 AM, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.2 > head: f153bf49ddf6169544b24ef5ea26fa3eb4996b95 > commit: 7e978fa37df7f771a5d02934ff828a0ee36bcf11 [248/316] ASoC: SOF: Add Build support for SOF core and Intel drivers > config: i386-randconfig-l1-05071509 (attached as .config) > compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010 > reproduce: > git checkout 7e978fa37df7f771a5d02934ff828a0ee36bcf11 > # save the attached .config to linux build tree > make ARCH=i386 > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot > > All errors (new ones prefixed by >>): > > ld: sound/soc/sof/core.o: in function `sof_machine_check': >>> sound/soc/sof/core.c:279: undefined reference to `sof_nocodec_setup' Ack. this is a confusion between if (IS_ENABLED(SND_SOC_SOF_NOCODEC)) and #if IS_ENABLED(SND_SOC_SOF_NOCODEC) Will send a formal fix shortly. > > vim +279 sound/soc/sof/core.c > > c16211d6 Liam Girdwood 2019-04-12 255 > c16211d6 Liam Girdwood 2019-04-12 256 /* > c16211d6 Liam Girdwood 2019-04-12 257 * SOF Driver enumeration. > c16211d6 Liam Girdwood 2019-04-12 258 */ > c16211d6 Liam Girdwood 2019-04-12 259 static int sof_machine_check(struct snd_sof_dev *sdev) > c16211d6 Liam Girdwood 2019-04-12 260 { > c16211d6 Liam Girdwood 2019-04-12 261 struct snd_sof_pdata *plat_data = sdev->pdata; > c16211d6 Liam Girdwood 2019-04-12 262 struct snd_soc_acpi_mach *machine; > c16211d6 Liam Girdwood 2019-04-12 263 int ret; > c16211d6 Liam Girdwood 2019-04-12 264 > c16211d6 Liam Girdwood 2019-04-12 265 if (plat_data->machine) > c16211d6 Liam Girdwood 2019-04-12 266 return 0; > c16211d6 Liam Girdwood 2019-04-12 267 > c16211d6 Liam Girdwood 2019-04-12 268 if (!IS_ENABLED(CONFIG_SND_SOC_SOF_NOCODEC)) { > c16211d6 Liam Girdwood 2019-04-12 269 dev_err(sdev->dev, "error: no matching ASoC machine driver found - aborting probe\n"); > c16211d6 Liam Girdwood 2019-04-12 270 return -ENODEV; > c16211d6 Liam Girdwood 2019-04-12 271 } > c16211d6 Liam Girdwood 2019-04-12 272 > c16211d6 Liam Girdwood 2019-04-12 273 /* fallback to nocodec mode */ > c16211d6 Liam Girdwood 2019-04-12 274 dev_warn(sdev->dev, "No ASoC machine driver found - using nocodec\n"); > c16211d6 Liam Girdwood 2019-04-12 275 machine = devm_kzalloc(sdev->dev, sizeof(*machine), GFP_KERNEL); > c16211d6 Liam Girdwood 2019-04-12 276 if (!machine) > c16211d6 Liam Girdwood 2019-04-12 277 return -ENOMEM; > c16211d6 Liam Girdwood 2019-04-12 278 > c16211d6 Liam Girdwood 2019-04-12 @279 ret = sof_nocodec_setup(sdev->dev, plat_data, machine, > c16211d6 Liam Girdwood 2019-04-12 280 plat_data->desc, plat_data->desc->ops); > c16211d6 Liam Girdwood 2019-04-12 281 if (ret < 0) > c16211d6 Liam Girdwood 2019-04-12 282 return ret; > c16211d6 Liam Girdwood 2019-04-12 283 > c16211d6 Liam Girdwood 2019-04-12 284 plat_data->machine = machine; > c16211d6 Liam Girdwood 2019-04-12 285 > c16211d6 Liam Girdwood 2019-04-12 286 return 0; > c16211d6 Liam Girdwood 2019-04-12 287 } > c16211d6 Liam Girdwood 2019-04-12 288 > > :::::: The code at line 279 was first introduced by commit > :::::: c16211d6226dbde8819b84da07508083a1138a06 ASoC: SOF: Add Sound Open Firmware driver core > > :::::: TO: Liam Girdwood > :::::: CC: Mark Brown > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation > > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel >