alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: David Henningsson <david.henningsson@canonical.com>
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Subject: Re: [PATCH RFC 0/7] Allow multiple callbacks for hda_jack
Date: Thu, 11 Sep 2014 17:14:00 +0200	[thread overview]
Message-ID: <5411BC38.5020503@canonical.com> (raw)
In-Reply-To: <1410445157-23198-1-git-send-email-tiwai@suse.de>



On 2014-09-11 16:19, Takashi Iwai wrote:
> Hi,
>
> this is a series of patches I quickly cooked up after the discussion
> in this morning: the support of multiple callbacks per jack.
>
> The series is applied on top of the previous fix patch (ALSA: hda -
> Fix invalid pin powermap without jack detection).  It begins with
> a couple of cleanups, then introduces the new hda_jack_callback
> struct and the changes along with it, then ends with another
> couple of cleanup patches based on the new infrastructure.
>
> I've tested only with a small set of devices, so far.

In general I like this idea and I remember thinking along the same lines.

I'm pondering whether we could use a more memory efficient layout for 
the callback list. Like allocating a snd_array on codec level and have 
indices to that list instead of pointers. Then the kernel would have 
less memory blocks to worry about. What do you think?

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic

  parent reply	other threads:[~2014-09-11 15:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11 14:19 [PATCH RFC 0/7] Allow multiple callbacks for hda_jack Takashi Iwai
2014-09-11 14:19 ` [PATCH RFC 1/7] ALSA: hda - Get rid of action field from struct hda_jack_tbl Takashi Iwai
2014-09-11 14:19 ` [PATCH RFC 2/7] ALSA: hda - Make snd_hda_jack_tbl_new() static Takashi Iwai
2014-09-11 14:19 ` [PATCH RFC 3/7] ALSA: hda - Make snd_hda_jack_detect_enable_callbac() returning the jack object Takashi Iwai
2014-09-11 14:44   ` David Henningsson
2014-09-15  8:40     ` Takashi Iwai
2014-09-11 14:19 ` [PATCH RFC 4/7] ALSA: hda - Allow multiple callbacks for jack Takashi Iwai
2014-09-11 15:01   ` David Henningsson
2014-09-15  8:41     ` Takashi Iwai
2014-09-11 14:19 ` [PATCH RFC 5/7] ALSA: hda - Remove superfluous callbacks from STAC/IDT codecs Takashi Iwai
2014-09-11 14:19 ` [PATCH RFC 6/7] ALSA: hda - Remove superfluous hooks from VIA driver Takashi Iwai
2014-09-11 14:19 ` [PATCH RFC 7/7] ALSA: hda - Use standard hda_jack infrastructure for CA0132 driver Takashi Iwai
2014-09-11 15:14 ` David Henningsson [this message]
2014-09-15  8:42   ` [PATCH RFC 0/7] Allow multiple callbacks for hda_jack Takashi Iwai
2014-09-15 12:11     ` Takashi Iwai
2014-09-16  8:33       ` David Henningsson
2014-09-16 14:36         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5411BC38.5020503@canonical.com \
    --to=david.henningsson@canonical.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).