From: Timur Tabi <timur@tabi.org>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: "Fabio.Estevam@freescale.com" <Fabio.Estevam@freescale.com>,
"Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"broonie@kernel.org" <broonie@kernel.org>
Subject: Re: [PATCH] ASoC: fsl_ssi: Remove unneeded 'i2s-slave' property
Date: Fri, 19 Sep 2014 07:51:46 -0500 [thread overview]
Message-ID: <541C26E2.4060605@tabi.org> (raw)
In-Reply-To: <20140919041749.GA5840@Asurada>
Nicolin Chen wrote:
>> You can't just redefine a property, because that breaks backwards
>> >compatibility with older device trees or older kernels.
> Sorry, I'm not sure what's the problem here. It just drops i2s stuff
> and leave AC97 part as we discussed. Why would old DTs be broken?
> Is that possible for you to give me an example to understand the
> point?
If you have an older kernel with a newer device tree (that doesn't have
"i2s-mode"), the driver will fail to load because "i2s-mode" is missing.
next prev parent reply other threads:[~2014-09-19 12:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1411063877-1552-1-git-send-email-fabio.estevam@freescale.com>
[not found] ` <20140918183251.GE6432@Asurada>
[not found] ` <541B2678.8000401@tabi.org>
2014-09-18 18:46 ` [PATCH] ASoC: fsl_ssi: Remove unneeded 'i2s-slave' property Fabio.Estevam
2014-09-18 19:43 ` Nicolin Chen
2014-09-19 0:29 ` Timur Tabi
2014-09-19 4:17 ` Nicolin Chen
2014-09-19 12:51 ` Timur Tabi [this message]
2014-09-19 17:24 ` Nicolin Chen
2014-09-19 23:49 ` Timur Tabi
2014-09-20 18:07 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541C26E2.4060605@tabi.org \
--to=timur@tabi.org \
--cc=Fabio.Estevam@freescale.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=nicoleotsuka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).