From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 03/12] ASoC: dapm: Only mark paths dirty when the connection status changed
Date: Wed, 22 Oct 2014 14:10:29 +0200 [thread overview]
Message-ID: <54479EB5.2060102@metafoo.de> (raw)
In-Reply-To: <20141022110012.GQ2344@sirena.org.uk>
On 10/22/2014 01:00 PM, Mark Brown wrote:
> On Mon, Oct 20, 2014 at 07:36:35PM +0200, Lars-Peter Clausen wrote:
>
>> +static bool soc_dapm_connect_path(struct snd_soc_dapm_path *path,
>> + bool connect, const char *reason)
>
> Why is this returning a value which is then ignored?
>
I was initially using it to not schedule the dapm_power_widgets(), but there
is potential for problems when the DAPM graph and the hardware state are
out-of-sync, in which case we still want to apply the register update. There
are some corner cases where this can happen and which need to be fixed first.
I can drop the return type for now.
- Lars
next prev parent reply other threads:[~2014-10-22 12:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 17:36 [PATCH 00/12] ASoC: dapm: Cleanups and speed-ups Lars-Peter Clausen
2014-10-20 17:36 ` [PATCH 01/12] ASoC: dapm: Reduce number of checked paths in dapm_widget_in_card_paths() Lars-Peter Clausen
2014-10-22 11:02 ` Mark Brown
2014-10-22 11:02 ` Mark Brown
2014-10-20 17:36 ` [PATCH 02/12] ASoC: dapm: Remove always true path source/sink checks Lars-Peter Clausen
2014-10-22 11:02 ` Mark Brown
2014-10-20 17:36 ` [PATCH 03/12] ASoC: dapm: Only mark paths dirty when the connection status changed Lars-Peter Clausen
2014-10-22 11:00 ` Mark Brown
2014-10-22 12:10 ` Lars-Peter Clausen [this message]
2014-10-22 15:29 ` Mark Brown
2014-10-20 17:36 ` [PATCH 04/12] ASoC: dapm: Do not add un-muxed paths to MUX control Lars-Peter Clausen
2014-10-20 17:36 ` [PATCH 05/12] ASoC: dapm: Do not pretend to support controls for non mixer/mux widgets Lars-Peter Clausen
2014-10-20 17:36 ` [PATCH 06/12] ASoC: dapm: Remove special DAI widget power check functions Lars-Peter Clausen
2014-10-22 11:12 ` Mark Brown
2014-10-20 17:36 ` [PATCH 07/12] ASoC: dapm: Remove path 'walked' flag Lars-Peter Clausen
2014-10-22 11:10 ` Mark Brown
2014-10-20 17:36 ` [PATCH 08/12] ASoC: dapm: Introduce toplevel widget categories Lars-Peter Clausen
2014-10-20 17:36 ` [PATCH 09/12] ASoC: dapm: Add a flag to mark paths connected to supply widgets Lars-Peter Clausen
2014-10-20 17:36 ` [PATCH 10/12] ASoC: dapm: Mark endpoints instead of IO widgets dirty during suspend/resume Lars-Peter Clausen
2014-10-20 17:36 ` [PATCH 11/12] ASoC: dapm: Add a few supply widget sanity checks Lars-Peter Clausen
2014-10-22 11:21 ` Mark Brown
2014-10-20 17:36 ` [PATCH 12/12] ASoC: dapm: Use more aggressive caching Lars-Peter Clausen
2014-10-22 11:36 ` [PATCH 00/12] ASoC: dapm: Cleanups and speed-ups Mark Brown
2014-10-25 13:58 ` Lars-Peter Clausen
2014-10-28 0:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54479EB5.2060102@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox