Re: [PATCH 4/4 v4] ALSA: usb-audio: Scarlett mixer interface for 6i6, 18i6, 18i8 and 18i20

[David Henningsson <david.henningsson@canonical.com>]

On 2014-11-03 23:58, Chris J Arges wrote:
> This code contains the Scarlett mixer interface code that was originally
> written by Tobias Hoffman and Robin Gareus. Because the device doesn't
> properly implement UAC2 this code adds a mixer quirk for the device.

Thanks a lot for taking over - it surely has been done with better speed 
than I would have.

> + *   Code cleanup:
> + *   David Henningsson <david.henningsson at canonical.com>

Thanks for the credit, not sure I deserve it though, all I did was to 
squash the patches and fix the checkpatch errors :-)

> +static int scarlett_ctl_save_put(struct snd_kcontrol *kctl,
> +				 struct snd_ctl_elem_value *ucontrol)
> +{
> +	struct usb_mixer_elem_info *elem = kctl->private_data;
> +	struct snd_usb_audio *chip = elem->mixer->chip;
> +	char buf[] = { 0x00, 0xa5 };
> +	int err;
> +
> +	if (ucontrol->value.enumerated.item[0] > 0) {
> +		err = snd_usb_ctl_msg(chip->dev,
> +			usb_sndctrlpipe(chip->dev, 0), UAC2_CS_MEM,
> +			USB_RECIP_INTERFACE | USB_TYPE_CLASS |
> +			USB_DIR_OUT, 0x005a, snd_usb_ctrl_intf(chip) |
> +			(0x3c << 8), buf, 2);
> +		if (err < 0)
> +			return err;
> +
> +		usb_audio_info(elem->mixer->chip,
> +			 "scarlett: saved settings to hardware.\n");
> +	}
> +	return 0;
> +}

To elaborate on Takashi's concern about this control, imagine e g what 
alsactl restore/store being run on startup/shutdown. On shutdown, 
alsactl store would read "0", and on startup, alsactl restore would 
write "0", with the result that the hw would not store the values set.

Would it be possible to have an autosave instead? E g, whenever a value 
is changed, it saves that value to the hardware. That's how other 
hardware works and what userspace expects.
If you want to avoid a lot of autosaves, e g if the autosave takes a lot 
of time before the hw responds, maybe you could do the autosave in a 10 
ms delayed_work, or similar.

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic