From: Lars-Peter Clausen <lars@metafoo.de>
To: bardliao@realtek.com
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
mengdong.lin@intel.com, lgirdwood@gmail.com, broonie@kernel.org,
yao.jin@intel.com, flove@realtek.com
Subject: Re: [PATCH 2/4] ASoC: rt5670: check if asrc is useable
Date: Wed, 12 Nov 2014 20:42:38 +0100 [thread overview]
Message-ID: <5463B82E.7070303@metafoo.de> (raw)
In-Reply-To: <1415793273-7844-2-git-send-email-bardliao@realtek.com>
On 11/12/2014 12:54 PM, bardliao@realtek.com wrote:
> From: Bard Liao <bardliao@realtek.com>
>
> To use ASRC, the sysclk should be faster than 384 times sample
> rate of I2S1.
>
> Signed-off-by: Bard Liao <bardliao@realtek.com>
> ---
> sound/soc/codecs/rt5670.c | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/rt5670.c b/sound/soc/codecs/rt5670.c
> index 85dc210..898b17f 100644
> --- a/sound/soc/codecs/rt5670.c
> +++ b/sound/soc/codecs/rt5670.c
> @@ -575,6 +575,17 @@ static int is_using_asrc(struct snd_soc_dapm_widget *source,
>
> }
>
> +static int can_use_asrc(struct snd_soc_dapm_widget *source,
> + struct snd_soc_dapm_widget *sink)
> +{
> + struct rt5670_priv *rt5670 = snd_soc_codec_get_drvdata(source->codec);
Can you start using snd_soc_dapm_to_codec(source->dapm) instead of
source->codec? The codec field will eventually be removed.
Bonus points for fixing up the existing w->codec users in rt drivers.
Thanks,
- Lars
next prev parent reply other threads:[~2014-11-12 19:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 11:54 [PATCH 1/4] ASoC: rt5670: make bias level more reasonable bardliao
2014-11-12 11:54 ` [PATCH 2/4] ASoC: rt5670: check if asrc is useable bardliao
2014-11-12 19:42 ` Lars-Peter Clausen [this message]
2014-11-14 11:38 ` Bard Liao
2014-11-14 15:11 ` Mark Brown
2014-11-12 11:54 ` [PATCH 3/4] ASoC: rt5670: add DMIC ASRC support bardliao
2014-11-12 11:54 ` [PATCH 4/4] ASoC: rt5670: add codec irq support bardliao
2014-11-14 11:11 ` [PATCH 1/4] ASoC: rt5670: make bias level more reasonable Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2014-11-12 6:21 bardliao
2014-11-12 6:21 ` [PATCH 2/4] ASoC: rt5670: check if asrc is useable bardliao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5463B82E.7070303@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=flove@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=mengdong.lin@intel.com \
--cc=oder_chiou@realtek.com \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox