From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Subject: Re: [PATCH] sound: use enum names instead of magic
	numbers
Date: Sun, 30 Nov 2014 13:52:02 +0900
Message-ID: <547AA272.6070308@sakamocchi.jp>
References: <1417201196-12392-1-git-send-email-KyleChamberlin@project20million.org>
 <s5h7fydbv6w.wl-tiwai@suse.de> <1417294692.818.3.camel@perches.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from smtp302.phy.lolipop.jp (smtp302.phy.lolipop.jp [210.157.22.85])
 by alsa0.perex.cz (Postfix) with ESMTP id F266A260434
 for <alsa-devel@alsa-project.org>; Sun, 30 Nov 2014 05:52:05 +0100 (CET)
In-Reply-To: <1417294692.818.3.camel@perches.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Joe Perches <joe@perches.com>, Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
List-Id: alsa-devel@alsa-project.org

T24gMjAxNOW5tDEx5pyIMzDml6UgMDU6NTgsIEpvZSBQZXJjaGVzIHdyb3RlOgo+IFRoZXJlJ3Mg
YW4gZW51bSBkZWZpbmVkIGZvciB0aGVzZSBtYWdpYyBudW1iZXJzLAo+IG1pZ2h0IGFzIHdlbGwg
dXNlIGl0Lgo+IAo+IE1pc2NlbGxhbmVhOgo+IG8gVXNlICMjX19WQV9BUkdTX18KPiAKPiBTaWdu
ZWQtb2ZmLWJ5OiBKb2UgUGVyY2hlcyA8am9lQHBlcmNoZXMuY29tPgo+IC0tLQo+ICBpbmNsdWRl
L3NvdW5kL2NvcmUuaCB8IDI4ICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0KPiAgc291bmQv
Y29yZS9taXNjLmMgICAgfCAgNiArKystLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRp
b25zKCspLCAxNiBkZWxldGlvbnMoLSkKCkkgdGhpbmsgaXQgYmV0dGVyIHRvIHNwbGl0IHRoaXMg
cGF0Y2ggaW50byB0d28gcGFydHMsIG9uZSBpcyBmb3IKZW51bWVyYXRpb24gaWRlbnRpZmllciBh
bmQgYW5vdGhlciBpcyBmb3IgdmFyaWFkaWMgbWFjcm8uCgo+IGRpZmYgLS1naXQgYS9pbmNsdWRl
L3NvdW5kL2NvcmUuaCBiL2luY2x1ZGUvc291bmQvY29yZS5oCj4gaW5kZXggMWRmM2YyZi4uNDA0
MThlNyAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL3NvdW5kL2NvcmUuaAo+ICsrKyBiL2luY2x1ZGUv
c291bmQvY29yZS5oCj4gQEAgLTMyNSw3ICszMjUsNyBAQCB2b2lkIHJlbGVhc2VfYW5kX2ZyZWVf
cmVzb3VyY2Uoc3RydWN0IHJlc291cmNlICpyZXMpOwo+ICAvKiAtLS0gKi8KPiAgCj4gIC8qIHNv
dW5kIHByaW50ayBkZWJ1ZyBsZXZlbHMgKi8KPiAtZW51bSB7Cj4gK2VudW0gc25kX2xldmVsIHsK
PiAgCVNORF9QUl9BTFdBWVMsCj4gIAlTTkRfUFJfREVCVUcsCj4gIAlTTkRfUFJfVkVSQk9TRSwK
PiBAQCAtMzMzLDExICszMzMsMTEgQEAgZW51bSB7Cj4gIAo+ICAjaWYgZGVmaW5lZChDT05GSUdf
U05EX0RFQlVHKSB8fCBkZWZpbmVkKENPTkZJR19TTkRfVkVSQk9TRV9QUklOVEspCj4gIF9fcHJp
bnRmKDQsIDUpCj4gLXZvaWQgX19zbmRfcHJpbnRrKHVuc2lnbmVkIGludCBsZXZlbCwgY29uc3Qg
Y2hhciAqZmlsZSwgaW50IGxpbmUsCj4gK3ZvaWQgX19zbmRfcHJpbnRrKGVudW0gc25kX2xldmVs
IHNuZF9sZXZlbCwgY29uc3QgY2hhciAqZmlsZSwgaW50IGxpbmUsCj4gIAkJICBjb25zdCBjaGFy
ICpmb3JtYXQsIC4uLik7Cj4gICNlbHNlCj4gLSNkZWZpbmUgX19zbmRfcHJpbnRrKGxldmVsLCBm
aWxlLCBsaW5lLCBmb3JtYXQsIGFyZ3MuLi4pIFwKPiAtCXByaW50ayhmb3JtYXQsICMjYXJncykK
PiArI2RlZmluZSBfX3NuZF9wcmludGsoc25kX2xldmVsLCBmaWxlLCBsaW5lLCBmb3JtYXQsIC4u
LikgXAo+ICsJcHJpbnRrKGZvcm1hdCwgIyNfX1ZBX0FSR1NfXykKPiAgI2VuZGlmCj4gIC8qKgo+
IEBAIC0zNDcsOCArMzQ3LDggQEAgdm9pZCBfX3NuZF9wcmludGsodW5zaWduZWQgaW50IGxldmVs
LCBjb25zdCBjaGFyICpmaWxlLCBpbnQgbGluZSwKPiAgICogV29ya3MgbGlrZSBwcmludGsoKSBi
dXQgcHJpbnRzIHRoZSBmaWxlIGFuZCB0aGUgbGluZSBvZiB0aGUgY2FsbGVyCj4gICAqIHdoZW4g
Y29uZmlndXJlZCB3aXRoIENPTkZJR19TTkRfVkVSQk9TRV9QUklOVEsuCj4gICAqLwo+IC0jZGVm
aW5lIHNuZF9wcmludGsoZm10LCBhcmdzLi4uKSBcCj4gLQlfX3NuZF9wcmludGsoMCwgX19GSUxF
X18sIF9fTElORV9fLCBmbXQsICMjYXJncykKPiArI2RlZmluZSBzbmRfcHJpbnRrKGZtdCwgLi4u
KSBcCj4gKwlfX3NuZF9wcmludGsoU05EX1BSX0FMV0FZUywgX19GSUxFX18sIF9fTElORV9fLCBm
bXQsICMjX19WQV9BUkdTX18pCj4gIAo+ICAjaWZkZWYgQ09ORklHX1NORF9ERUJVRwo+ICAvKioK
PiBAQCAtMzU4LDEwICszNTgsMTAgQEAgdm9pZCBfX3NuZF9wcmludGsodW5zaWduZWQgaW50IGxl
dmVsLCBjb25zdCBjaGFyICpmaWxlLCBpbnQgbGluZSwKPiAgICogV29ya3MgbGlrZSBzbmRfcHJp
bnRrKCkgZm9yIGRlYnVnZ2luZyBwdXJwb3Nlcy4KPiAgICogSWdub3JlZCB3aGVuIENPTkZJR19T
TkRfREVCVUcgaXMgbm90IHNldC4KPiAgICovCj4gLSNkZWZpbmUgc25kX3ByaW50ZChmbXQsIGFy
Z3MuLi4pIFwKPiAtCV9fc25kX3ByaW50aygxLCBfX0ZJTEVfXywgX19MSU5FX18sIGZtdCwgIyNh
cmdzKQo+IC0jZGVmaW5lIF9zbmRfcHJpbnRkKGxldmVsLCBmbXQsIGFyZ3MuLi4pIFwKPiAtCV9f
c25kX3ByaW50ayhsZXZlbCwgX19GSUxFX18sIF9fTElORV9fLCBmbXQsICMjYXJncykKPiArI2Rl
ZmluZSBzbmRfcHJpbnRkKGZtdCwgLi4uKSBcCj4gKwlfX3NuZF9wcmludGsoU05EX1BSX0RFQlVH
LCBfX0ZJTEVfXywgX19MSU5FX18sIGZtdCwgIyNfX1ZBX0FSR1NfXykKPiArI2RlZmluZSBfc25k
X3ByaW50ZChsZXZlbCwgZm10LCAuLi4pIFwKPiArCV9fc25kX3ByaW50ayhsZXZlbCwgX19GSUxF
X18sIF9fTElORV9fLCBmbXQsICMjX19WQV9BUkdTX18pCj4gIAo+ICAvKioKPiAgICogc25kX0JV
RyAtIGdpdmUgYSBCVUcgd2FybmluZyBtZXNzYWdlIGFuZCBzdGFjayB0cmFjZQo+IEBAIC0zOTAs
NyArMzkwLDggQEAgdm9pZCBfX3NuZF9wcmludGsodW5zaWduZWQgaW50IGxldmVsLCBjb25zdCBj
aGFyICpmaWxlLCBpbnQgbGluZSwKPiAgX19wcmludGYoMSwgMikKPiAgc3RhdGljIGlubGluZSB2
b2lkIHNuZF9wcmludGQoY29uc3QgY2hhciAqZm9ybWF0LCAuLi4pIHt9Cj4gIF9fcHJpbnRmKDIs
IDMpCj4gLXN0YXRpYyBpbmxpbmUgdm9pZCBfc25kX3ByaW50ZChpbnQgbGV2ZWwsIGNvbnN0IGNo
YXIgKmZvcm1hdCwgLi4uKSB7fQo+ICtzdGF0aWMgaW5saW5lIHZvaWQgX3NuZF9wcmludGQoZW51
bSBzbmRfbGV2ZWwgc25kX2xldmVsLAo+ICsJCQkgICAgICAgY29uc3QgY2hhciAqZm9ybWF0LCAu
Li4pIHt9Cj4gIAo+ICAjZGVmaW5lIHNuZF9CVUcoKQkJCWRvIHsgfSB3aGlsZSAoMCkKPiAgCj4g
QEAgLTQxMSw4ICs0MTIsOSBAQCBzdGF0aWMgaW5saW5lIGJvb2wgc25kX3ByaW50ZF9yYXRlbGlt
aXQodm9pZCkgeyByZXR1cm4gZmFsc2U7IH0KPiAgICogV29ya3MgbGlrZSBzbmRfcHJpbnRrKCkg
Zm9yIGRlYnVnZ2luZyBwdXJwb3Nlcy4KPiAgICogSWdub3JlZCB3aGVuIENPTkZJR19TTkRfREVC
VUdfVkVSQk9TRSBpcyBub3Qgc2V0Lgo+ICAgKi8KPiAtI2RlZmluZSBzbmRfcHJpbnRkZChmb3Jt
YXQsIGFyZ3MuLi4pIFwKPiAtCV9fc25kX3ByaW50aygyLCBfX0ZJTEVfXywgX19MSU5FX18sIGZv
cm1hdCwgIyNhcmdzKQo+ICsjZGVmaW5lIHNuZF9wcmludGRkKGZvcm1hdCwgLi4uKQkJCQlcCj4g
KwlfX3NuZF9wcmludGsoU05EX1BSX1ZFUkJPU0UsIF9fRklMRV9fLCBfX0xJTkVfXywJXAo+ICsJ
CSAgICAgZm9ybWF0LCAjI19fVkFfQVJHU19fKQo+ICAjZWxzZQo+ICBfX3ByaW50ZigxLCAyKQo+
ICBzdGF0aWMgaW5saW5lIHZvaWQgc25kX3ByaW50ZGQoY29uc3QgY2hhciAqZm9ybWF0LCAuLi4p
IHt9Cj4gZGlmZiAtLWdpdCBhL3NvdW5kL2NvcmUvbWlzYy5jIGIvc291bmQvY29yZS9taXNjLmMK
PiBpbmRleCBmMmU4MjI2Li4wM2IzZjU2IDEwMDY0NAo+IC0tLSBhL3NvdW5kL2NvcmUvbWlzYy5j
Cj4gKysrIGIvc291bmQvY29yZS9taXNjLmMKPiBAQCAtNjMsNyArNjMsNyBAQCBzdGF0aWMgY29u
c3QgY2hhciAqc2FuaXR5X2ZpbGVfbmFtZShjb25zdCBjaGFyICpwYXRoKQo+ICAjZW5kaWYKPiAg
Cj4gICNpZiBkZWZpbmVkKENPTkZJR19TTkRfREVCVUcpIHx8IGRlZmluZWQoQ09ORklHX1NORF9W
RVJCT1NFX1BSSU5USykKPiAtdm9pZCBfX3NuZF9wcmludGsodW5zaWduZWQgaW50IGxldmVsLCBj
b25zdCBjaGFyICpwYXRoLCBpbnQgbGluZSwKPiArdm9pZCBfX3NuZF9wcmludGsoZW51bSBzbmRf
bGV2ZWwgc25kX2xldmVsLCBjb25zdCBjaGFyICpwYXRoLCBpbnQgbGluZSwKPiAgCQkgIGNvbnN0
IGNoYXIgKmZvcm1hdCwgLi4uKQo+ICB7Cj4gIAl2YV9saXN0IGFyZ3M7Cj4gQEAgLTc0LDcgKzc0
LDcgQEAgdm9pZCBfX3NuZF9wcmludGsodW5zaWduZWQgaW50IGxldmVsLCBjb25zdCBjaGFyICpw
YXRoLCBpbnQgbGluZSwKPiAgI2VuZGlmCj4gIAo+ICAjaWZkZWYgQ09ORklHX1NORF9ERUJVRwo+
IC0JaWYgKGRlYnVnIDwgbGV2ZWwpCj4gKwlpZiAoZGVidWcgPCBzbmRfbGV2ZWwpCj4gIAkJcmV0
dXJuOwo+ICAjZW5kaWYKPiAgCj4gQEAgLTg4LDcgKzg4LDcgQEAgdm9pZCBfX3NuZF9wcmludGso
dW5zaWduZWQgaW50IGxldmVsLCBjb25zdCBjaGFyICpwYXRoLCBpbnQgbGluZSwKPiAgCQljb25z
dCBjaGFyICplbmRfb2ZfaGVhZGVyID0gcHJpbnRrX3NraXBfbGV2ZWwoZm9ybWF0KTsKPiAgCQlt
ZW1jcHkodmVyYm9zZV9mbXQsIGZvcm1hdCwgZW5kX29mX2hlYWRlciAtIGZvcm1hdCk7Cj4gIAkJ
dmFmLmZtdCA9IGVuZF9vZl9oZWFkZXI7Cj4gLQl9IGVsc2UgaWYgKGxldmVsKQo+ICsJfSBlbHNl
IGlmIChzbmRfbGV2ZWwpCj4gIAkJbWVtY3B5KHZlcmJvc2VfZm10LCBLRVJOX0RFQlVHLCBzaXpl
b2YoS0VSTl9ERUJVRykgLSAxKTsKPiAgCXByaW50ayh2ZXJib3NlX2ZtdCwgc2FuaXR5X2ZpbGVf
bmFtZShwYXRoKSwgbGluZSwgJnZhZik7CgpUaGVyZSdzIG5vIG5lZWQgdG8gcmVuYW1lIHZhcmlh
YmxlIG5hbWVzLgoKClJlZ2FyZHMKClRha2FzaGkgU2FrYW1vdG8Kby10YWthc2hpQHNha2Ftb2Nj
aGkuanAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFs
c2EtZGV2ZWwgbWFpbGluZyBsaXN0CkFsc2EtZGV2ZWxAYWxzYS1wcm9qZWN0Lm9yZwpodHRwOi8v
bWFpbG1hbi5hbHNhLXByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vYWxzYS1kZXZlbAo=