From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jackson Subject: Re: [PATCH 4/5] ASoC: dwc: Add devicetree support for Designware I2S Date: Thu, 04 Dec 2014 09:43:57 +0000 Message-ID: <54802CDD.6080000@arm.com> References: <547F3CAC.9050105@arm.com> <2041200.ZjakFFAZAU@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cam-smtp0.cambridge.arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by alsa0.perex.cz (Postfix) with ESMTP id C4A7E2606D3 for ; Thu, 4 Dec 2014 10:43:57 +0100 (CET) In-Reply-To: <2041200.ZjakFFAZAU@wuerfel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" Cc: "alsa-devel@alsa-project.org" , Takashi Iwai , Liviu Dudau , "linux-kernel@vger.kernel.org" , Liam Girdwood , Mark Brown , Rajeev Kumar List-Id: alsa-devel@alsa-project.org On 12/03/14 20:13, Arnd Bergmann wrote: > On Wednesday 03 December 2014 16:39:08 Andrew Jackson wrote: >> Convert to driver to use either platform_data or device-tree for configuration >> of the device. When using device-tree, the I2S block's configuration is read >> from the relevant registers: this reduces the amount of information required in >> the device tree. >> >> Signed-off-by: Andrew Jackson > > I don't think we even have to worry about the platform_data case here: > the only platform using this hardware in Linux is arm/mach-spear, and > it defines a device node with a binding that is similar to the one you > document here but that is not implemented in the driver. > > So, I think for all practical purposes we can assume that nobody cares > if you make incompatible changes as long as you don't introduce build > regression. > > Also, please adapt the arch/arm/boot/dts/spear13*.dts{,i} files > as good as you can. They are broken in other ways too that you don't > have to fix, just make them conform to the binding you add. > Will do. Although I had noticed those DT entries, I couldn't find anything in support of them. I wasn't sure whether someone else was waiting in the wings (so as to speak) with a DT enabled Designware I2S driver. > Arnd > >