From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org,
padma.v@samsung.com, drake@endlessm.com, sbkim73@samsung.com
Subject: Re: [PATCH/RFC 04/14] ASoC: samsung: i2s: Request memory region in driver probe()
Date: Wed, 17 Dec 2014 16:10:32 +0100 [thread overview]
Message-ID: <54919CE8.1070800@samsung.com> (raw)
In-Reply-To: <20141212184927.GR11764@sirena.org.uk>
On 12/12/14 19:49, Mark Brown wrote:
> On Thu, Dec 11, 2014 at 06:45:42PM +0100, Sylwester Nawrocki wrote:
>> > The memory mapped registers region is common for both DAIs so request
>> > it in the I2S platform device driver's probe for the platform device
>> > corresponding to the primary DAI, rather than in the ASoC DAI's probe
>> > callback. While at it switch to devm_ioremap_resource(). This also
>> > drops the hard coded (0x100) register region size in the driver.
>
> This doesn't apply against current code, please check and resend.
It seems I've used your topic/samsung branch as a base. Let me rebase
to the for-next branch and resend.
--
Regards,
Sylwester
next prev parent reply other threads:[~2014-12-17 15:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 17:45 [PATCH/RFC 00/14] ASoC: samsung: Add clk provider for I2S internal clocks Sylwester Nawrocki
2014-12-11 17:45 ` [PATCH/RFC 01/14] ASoC: samsung: i2s: Remove unused gpios field from struct i2s Sylwester Nawrocki
2014-12-11 17:45 ` [PATCH/RFC 02/14] ASoC: samsung: i2s: samsung_i2s_get_driver_data() cleanup Sylwester Nawrocki
2014-12-11 17:45 ` [PATCH/RFC 03/14] ASoC: samsung: i2s: Add return value checks in probe() Sylwester Nawrocki
2014-12-11 17:45 ` [PATCH/RFC 04/14] ASoC: samsung: i2s: Request memory region in driver probe() Sylwester Nawrocki
2014-12-12 18:49 ` Mark Brown
2014-12-17 15:10 ` Sylwester Nawrocki [this message]
2014-12-11 17:45 ` [PATCH/RFC 05/14] ASoC: samsung: i2s: Move clk_get() to platform " Sylwester Nawrocki
2014-12-11 17:45 ` [PATCH/RFC 06/14] ASoC: samsung: i2s: Move clk enable to the " Sylwester Nawrocki
2014-12-11 17:45 ` [PATCH/RFC 07/14] ASoC: samsung: i2s: Add get_other_dai helper function Sylwester Nawrocki
2014-12-11 17:45 ` [PATCH/RFC 08/14] ASoC: samsung: i2s: Remove an unneeded goto usage Sylwester Nawrocki
2014-12-11 17:45 ` [PATCH/RFC 09/14] ASoC: samsung: i2s: Add spinlock in place of local_irq_* calls Sylwester Nawrocki
2014-12-11 17:45 ` [PATCH/RFC 10/14] ASoC: samsung: i2s: Protect access to more registers with a spinlock Sylwester Nawrocki
2014-12-11 17:45 ` [PATCH/RFC 11/14] ASoC: samsung: odroidx2: Handle I2S CDCLK clock conditionally Sylwester Nawrocki
2014-12-12 18:53 ` Mark Brown
2014-12-17 15:18 ` Sylwester Nawrocki
2014-12-11 17:45 ` [PATCH/RFC 12/14] ASoC: samsung: i2s: Add clock provider for the I2S internal clocks Sylwester Nawrocki
2014-12-12 20:03 ` [alsa-devel] " Mark Brown
2014-12-17 17:00 ` Sylwester Nawrocki
2014-12-11 17:45 ` [PATCH/RFC 13/14] ARM: dts: Exynos4 and Odroid X2/U3 sound device nodes update Sylwester Nawrocki
2014-12-11 17:45 ` [PATCH/RFC 14/14] ARM: dts: Switch Odroid X2/U2 to simple-audio-card Sylwester Nawrocki
2014-12-16 3:16 ` [alsa-devel] [PATCH/RFC 00/14] ASoC: samsung: Add clk provider for I2S internal clocks Padma Venkat
2014-12-19 13:53 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54919CE8.1070800@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=drake@endlessm.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=padma.v@samsung.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox