From: Randy Dunlap <rdunlap@infradead.org>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
alsa-devel@alsa-project.org
Cc: Mengdong Lin <mengdong.lin@intel.com>,
Mark Brown <broonie@kernel.org>,
"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: Intel: Add I2C dependency to two new machines
Date: Thu, 18 Dec 2014 12:32:38 -0800 [thread overview]
Message-ID: <549339E6.7000602@infradead.org> (raw)
In-Reply-To: <1418913635-7422-1-git-send-email-jarkko.nikula@linux.intel.com>
On 12/18/14 06:40, Jarkko Nikula wrote:
> Fix following build error when CONFIG_I2C is not enabled:
>
> sound/soc/codecs/rt5640.c:2252:1: warning: data definition has no type or storage class
> module_i2c_driver(rt5640_i2c_driver);
> ^
> sound/soc/codecs/rt5640.c:2252:1: error: type defaults to ‘int’ in declaration of ‘module_i2c_driver’ [-Werror=implicit-int]
> sound/soc/codecs/rt5640.c:2252:1: warning: parameter names (without types) in function declaration
> sound/soc/codecs/rt5640.c:2241:26: warning: ‘rt5640_i2c_driver’ defined but not used [-Wunused-variable]
> static struct i2c_driver rt5640_i2c_driver = {
> ^
> cc1: some warnings being treated as errors
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> Cc: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
> Cc: Mengdong Lin <mengdong.lin@intel.com>
> ---
> sound/soc/intel/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index e989ecf046c9..f86de1211b96 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -89,7 +89,7 @@ config SND_SOC_INTEL_BROADWELL_MACH
>
> config SND_SOC_INTEL_BYTCR_RT5640_MACH
> tristate "ASoC Audio DSP Support for MID BYT Platform"
> - depends on X86
> + depends on X86 && I2C
> select SND_SOC_RT5640
> select SND_SST_MFLD_PLATFORM
> select SND_SST_IPC_ACPI
> @@ -101,7 +101,7 @@ config SND_SOC_INTEL_BYTCR_RT5640_MACH
>
> config SND_SOC_INTEL_CHT_BSW_RT5672_MACH
> tristate "ASoC Audio driver for Intel Cherrytrail & Braswell with RT5672 codec"
> - depends on X86_INTEL_LPSS
> + depends on X86_INTEL_LPSS && I2C
> select SND_SOC_RT5670
> select SND_SST_MFLD_PLATFORM
> select SND_SST_IPC_ACPI
>
--
~Randy
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2014-12-18 20:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 14:40 [PATCH] ASoC: Intel: Add I2C dependency to two new machines Jarkko Nikula
2014-12-18 20:32 ` Randy Dunlap [this message]
2014-12-22 12:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549339E6.7000602@infradead.org \
--to=rdunlap@infradead.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=mengdong.lin@intel.com \
--cc=subhransu.s.prusty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox