alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Manuel Reinhardt <manuel.rhdt@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ALSA: usb-audio: Add quirk for MOTU MicroBook	II
Date: Thu, 28 Feb 2019 20:34:23 +0100	[thread overview]
Message-ID: <549a5ba4dbb973d891cc5b08bf0281ff1e171f94.camel@gmail.com> (raw)
In-Reply-To: <s5hr2btgnm9.wl-tiwai@suse.de>

Thank you for your time and comments.

Am Mittwoch, den 27.02.2019, 18:14 +0100 schrieb Takashi Iwai:
> On Wed, 27 Feb 2019 15:26:01 +0100,
> Manuel Reinhardt wrote:
> > Add an entry to the quirks-table to for usb-audio to recognize the
> > Microbook II (although it only exposes vendor interfaces). A simple
> > boot
> > quirk is also implemented to set up the sample rate and  make sure
> > that
> > no audio urbs are sent before the device is ready.
> > 
> > This patch only provides audio playback and capture at 96kHz sample
> > rate. Notice the following shortcomings:
> > 
> > - The sample rate is currently hardcoded to 96k although the device
> > also
> >   supports 48k and 44.1k.
> > 
> > - The various mixer controls of the MicroBook are not made
> > available.
> > 
> > - The keep-iface control should be on by default because the device
> >   shuts down whenever the altsetting is reset which is usually
> > unwanted.
> >   (I don't know the best way to do this)
> 
> Can be set either in the quirk callback you write.
> Or it'd be not bad to create a white list, too.

I will try to address that in a future patch.

I have fixed the patch to address your remaining concerns.

  reply	other threads:[~2019-02-28 19:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-27 14:26 [PATCH] ALSA: usb-audio: Add quirk for MOTU MicroBook II Manuel Reinhardt
2019-02-27 17:14 ` Takashi Iwai
2019-02-28 19:34   ` Manuel Reinhardt [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-02-28 19:34 Manuel Reinhardt
2019-02-28 21:24 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=549a5ba4dbb973d891cc5b08bf0281ff1e171f94.camel@gmail.com \
    --to=manuel.rhdt@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).