alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Bo Shen <voice.shen@atmel.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] sound: soc: atmel sam9g20_wm8731: remove useless include
Date: Tue, 6 Jan 2015 18:14:12 +0800	[thread overview]
Message-ID: <54ABB574.30602@atmel.com> (raw)
In-Reply-To: <1420536080-29181-1-git-send-email-alexandre.belloni@free-electrons.com>

Hi Alexandre Belloni,

On 01/06/2015 05:21 PM, Alexandre Belloni wrote:
> A mach/ header is included but never used. Simply remove it.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Thanks for your patch.

Acked-by: Bo Shen <voice.shen@atmel.com>

> ---
>   sound/soc/atmel/sam9g20_wm8731.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
> index 66b66d0e7514..531728975bbb 100644
> --- a/sound/soc/atmel/sam9g20_wm8731.c
> +++ b/sound/soc/atmel/sam9g20_wm8731.c
> @@ -47,7 +47,6 @@
>   #include <sound/soc.h>
>
>   #include <asm/mach-types.h>

Btw, do you consider to remove this also?

> -#include <mach/hardware.h>
>
>   #include "../codecs/wm8731.h"
>   #include "atmel-pcm.h"
>

Best Regards,
Bo Shen

  reply	other threads:[~2015-01-06 10:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-06  9:21 [PATCH] sound: soc: atmel sam9g20_wm8731: remove useless include Alexandre Belloni
2015-01-06 10:14 ` Bo Shen [this message]
2015-01-06 11:15   ` Alexandre Belloni
2015-01-06 17:45 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54ABB574.30602@atmel.com \
    --to=voice.shen@atmel.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).