Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Pascal Huerst <pascal.huerst@gmail.com>, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: davinci-mcasp: Correct rx format unit configuration
Date: Wed, 14 Jan 2015 14:33:32 +0200	[thread overview]
Message-ID: <54B6621C.7060505@ti.com> (raw)
In-Reply-To: <54B64EC4.6040600@gmail.com>

On 01/14/2015 01:11 PM, Pascal Huerst wrote:
> Hey Peter, all,
> 
> the patch (8e3006d02b46a722729a3bbd6a774eae99c6c8b8), causes lots of
> terrible noise on a custom built am33xx based board, if I map the input
> to the output like so:
> 
> arecord -f S16_LE -r 48000 -c2 -D hw:0,1 -F 0 --period-size=102
> 4 -B 0 --buffer-size=4096 | aplay -D hw:0,0 -

FWIW the -F0 and -B0 is redundant and you can use -fdat instead of -f S16_LE
-r 48000 -c2

> If I undo your changes, everything works fine. Tested with 3.14.23 and
> 3.18.1.

You mean only this single commit?

> Do you have any Idea, what might cause that behavior?

No, I don't. I quickly checked on am335x, am437x and on J6 boards and the
command you are using works w/o any issue or distortion in recorded audio.

what codec or codecs are you using? I see that you record from hw:0,1 and play
it back to hw:0,0
Can you check if the recorded sample alone is correct? Just record it to a
file and look at it on the PC. I did the same and the recorded sample looks
fine on my PC as well.

Looking at the patch again, I still think it is a valid fix.

-- 
Péter
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2015-01-14 12:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-04  7:52 [alsa-devel] [PATCH] ASoC: davinci-mcasp: Correct rx format unit configuration Peter Ujfalusi
2014-09-04 11:45 ` Mark Brown
2015-01-14 11:11 ` Pascal Huerst
2015-01-14 12:33   ` Peter Ujfalusi [this message]
2015-01-14 13:24     ` Pascal Huerst
2015-01-14 14:17       ` Peter Ujfalusi
2015-01-14 15:05         ` Pascal Huerst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B6621C.7060505@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=pascal.huerst@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox