Re: [PATCH] ASoC: OMAP: mcbsp: ensure that CLKX and CLKR are not used as ouput pins when they are used as input clock for the SRG.

From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: niederp@physik.uni-kl.de
Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
	jarkko.nikula@bitmer.com
Subject: Re: [PATCH] ASoC: OMAP: mcbsp: ensure that CLKX and CLKR are not used as ouput pins when they are used as input clock for the SRG.
Date: Mon, 19 Jan 2015 09:44:51 +0200	[thread overview]
Message-ID: <54BCB5F3.6000704@ti.com> (raw)
In-Reply-To: <1421420798.2546.22.camel@ag-ott-thomas.physik.uni-kl.de>

On 01/16/2015 05:06 PM, Thomas Niederprüm wrote:
>> Unfortunately the omap-mcbsp driver only supports synchronous configuration
>> for tx/rx (since almost all McBSP instance can only be used this way). The
>> first stream will configure both tx and rx to have the same properties. Even
>> if you are using McBSP1 which has separate FSX and FSR lines, the driver does
>> not have support for this.
>> From HW point of view this configuration is valid (not something I would
>> expect in any product). I don't think there are or will be other designs than
>> your using this mode... But, if you add some comment around the masking of
>> CLKXM and CLKRM bits that would be great.
> 
> Do you mean adding it to the commit message or to the code? or both?

Since this is something that the driver has not meant to support officially, I
prefer both. I just hope that HW designers will not get ideas based on this ;)

-- 
Péter
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel