From: Jiri Slaby <jslaby@suse.cz>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/3] sound: dummy, use del_timer_sync
Date: Mon, 19 Jan 2015 10:59:14 +0100 [thread overview]
Message-ID: <54BCD572.7060203@suse.cz> (raw)
In-Reply-To: <s5hvbk3qeq9.wl-tiwai@suse.de>
On 01/19/2015, 10:52 AM, Takashi Iwai wrote:
> At Mon, 19 Jan 2015 10:42:55 +0100,
> Jiri Slaby wrote:
>>
>> Wait for the timer to really quit, not only by ensuring it is not in
>> the critical section.
>>
>> BTW the spin_lock in here does not disable BH, so that it could
>> deadlock.
>
> The stop function is called from the PCM trigger callback which is
> irq-disabled. So, you can't use del_timer_sync() here.
The same as 3/3 I was looking at compr* :(. Ignore this one, then.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2015-01-19 9:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 9:42 [PATCH 1/3] sound: dummy, use setup_timer and mod_timer Jiri Slaby
2015-01-19 9:42 ` [PATCH 2/3] sound: dummy, use del_timer_sync Jiri Slaby
2015-01-19 9:52 ` Takashi Iwai
2015-01-19 9:59 ` Jiri Slaby [this message]
2015-01-19 9:42 ` [PATCH 3/3] sound: dummy, avoid races with timer Jiri Slaby
2015-01-19 9:49 ` Takashi Iwai
2015-01-19 9:53 ` Jiri Slaby
2015-01-19 9:56 ` [PATCH v2 2/2] sound: dummy, avoid race " Jiri Slaby
2015-01-19 9:59 ` Takashi Iwai
2015-01-19 9:53 ` [PATCH 1/3] sound: dummy, use setup_timer and mod_timer Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BCD572.7060203@suse.cz \
--to=jslaby@suse.cz \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).