From: Lars-Peter Clausen <lars@metafoo.de>
To: "Thomas Niederprüm" <niederp@physik.uni-kl.de>,
broonie@kernel.org, zonque@gmail.com, brandau@gmx.de
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 00/10] ASoC: sta32x: Add device tree binding
Date: Thu, 22 Jan 2015 14:05:50 +0100 [thread overview]
Message-ID: <54C0F5AE.7060702@metafoo.de> (raw)
In-Reply-To: <1421881322-27806-1-git-send-email-niederp@physik.uni-kl.de>
On 01/22/2015 12:01 AM, Thomas Niederprüm wrote:
> This patchset is the result of comparing the sta32x driver with the sta350
> driver with the goal to make the sta32x driver device tree capable. In the
> merging process the coding style of the sta350 driver was adopted since it
> seemed more up to date. I did my best to break up the changes in logical
> chunks. Additionally some small fixes were added.
>
> The comparison with the sta350 lead to the following changes:
> - Switch to direct usage of the regmap API
> - Use the kernel gpio framework to control the reset pin of the sta32x
> - adopt calculation of mlck divider and extrapolation ratio from sta350
> - add device tree bindings
> - Change the Codecs DAI name to be coherent with the sta350 driver
>
> Moreover some minor fixes were added:
> - Add the status register
> - Fix bit shift value for the IDE bit in the CONFF register
> - Add description for the driver and I2C dependency in Kconfig
>
Good stuff.
Do you think we can actually merge the the two drivers into one. They seem
to be 90% line-by-line identical.
Thanks,
- Lars
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2015-01-22 13:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 23:01 [PATCH 00/10] ASoC: sta32x: Add device tree binding Thomas Niederprüm
2015-01-21 23:01 ` [PATCH 01/10] ASoC: sta32x: Convert to direct regmap API usage Thomas Niederprüm
2015-01-21 23:01 ` [PATCH 02/10] ASoC: sta32x: make sta32x a gpio consumer for the reset GPIO Thomas Niederprüm
2015-01-27 17:00 ` Mark Brown
2015-01-21 23:01 ` [PATCH 03/10] ASoC: sta32x: use DECLARE_TLV_DB_RANGE macro Thomas Niederprüm
2015-01-21 23:01 ` [PATCH 04/10] ASoC: sta32x: add status register Thomas Niederprüm
2015-01-27 17:03 ` Mark Brown
2015-01-21 23:01 ` [PATCH 05/10] ASoC: sta32x: move code to calculate mclk divider and extrapolation ratio to sta32x_hw_params() Thomas Niederprüm
2015-01-21 23:01 ` [PATCH 06/10] ASoC: sta32x: add device tree binding Thomas Niederprüm
2015-01-21 23:01 ` [PATCH 07/10] ASoC: sta32x: use dev_dbg() for debug output Thomas Niederprüm
2015-01-21 23:02 ` [PATCH 08/10] ASoC: sta32x: minor Kconfig update Thomas Niederprüm
2015-01-21 23:02 ` [PATCH 09/10] ASoC: sta32x: correct bit shift value for IDE register Thomas Niederprüm
2015-01-27 17:09 ` Mark Brown
2015-01-21 23:02 ` [PATCH 10/10] ASoC: sta32x: change dai name to be in line with the sta350 driver Thomas Niederprüm
2015-01-22 13:05 ` Lars-Peter Clausen [this message]
2015-01-22 13:12 ` [PATCH 00/10] ASoC: sta32x: Add device tree binding Daniel Mack
2015-01-22 20:46 ` Thomas Niederprüm
2015-01-27 17:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C0F5AE.7060702@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=brandau@gmx.de \
--cc=broonie@kernel.org \
--cc=niederp@physik.uni-kl.de \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).