Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: [PATCH 3/6] ALSA: seq: fix off-by-one error in port limit check
Date: Sun, 25 Jan 2015 14:35:24 +0100	[thread overview]
Message-ID: <54C4F11C.1090903@ladisch.de> (raw)
In-Reply-To: <54C4F0A1.2000907@ladisch.de>

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
---
 sound/core/seq/seq_ports.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/core/seq/seq_ports.c b/sound/core/seq/seq_ports.c
index 794a341..52b279b 100644
--- a/sound/core/seq/seq_ports.c
+++ b/sound/core/seq/seq_ports.c
@@ -134,7 +134,7 @@ struct snd_seq_client_port *snd_seq_create_port(struct snd_seq_client *client,
 	if (snd_BUG_ON(!client))
 		return NULL;

-	if (client->num_ports >= SNDRV_SEQ_MAX_PORTS - 1) {
+	if (client->num_ports >= SNDRV_SEQ_MAX_PORTS) {
 		pr_warn("ALSA: seq: too many ports for client %d\n", client->number);
 		return NULL;
 	}

  parent reply	other threads:[~2015-01-25 13:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-25 13:33 [PATCH 0/6] sequencer fixes Clemens Ladisch
2015-01-25 13:34 ` [PATCH 1/6] ALSA: seq-dummy: remove deadlock-causing events on close Clemens Ladisch
2015-01-26 12:53   ` Takashi Iwai
2015-01-25 13:34 ` [PATCH 2/6] ALSA: seq: correctly report maximum number of ports Clemens Ladisch
2015-01-26 13:37   ` Takashi Iwai
2015-01-25 13:35 ` Clemens Ladisch [this message]
2015-01-25 13:35 ` [PATCH 4/6] ALSA: seq: remove unused symbols Clemens Ladisch
2015-01-25 13:36 ` [PATCH 5/6] ALSA: seq: remove unused callback_all field Clemens Ladisch
2015-01-25 13:36 ` [PATCH 6/6] ALSA: seq: increase the maximum number of queues Clemens Ladisch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C4F11C.1090903@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox