From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH v2 1/3] ARM: shmobile: armadillo800eva: Properly specify HDMI audio link format Date: Tue, 27 Jan 2015 09:19:57 +0100 Message-ID: <54C74A2D.6000606@metafoo.de> References: <1421847492-8857-1-git-send-email-lars@metafoo.de> <8761bsacx5.wl%kuninori.morimoto.gx@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <8761bsacx5.wl%kuninori.morimoto.gx@renesas.com> Sender: linux-sh-owner@vger.kernel.org To: Kuninori Morimoto Cc: Mark Brown , Liam Girdwood , Simon Horman , Magnus Damm , linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On 01/27/2015 08:40 AM, Kuninori Morimoto wrote: > > Hi Lars > > Thank you for your patch > >> The DAI link format should be specified for the whole link rather than just >> one component on the link. So move the format specification for the HDMI >> audio link from the CPU component to the link itself. >> >> Since the sh-mobile-hdmi DAI driver doesn't implement the set_fmt() callback >> in this case there is no functional difference between only specifying the >> the format for the CPU side or for the whole link, but the later it will >> allow us to remove support for just specifying the format for one component. >> >> Signed-off-by: Lars-Peter Clausen >> --- >> No changes since v1. >> --- >> arch/arm/mach-shmobile/board-armadillo800eva.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c b/arch/arm/mach-shmobile/board-armadillo800eva.c >> index 6d949f1..75de26c 100644 >> --- a/arch/arm/mach-shmobile/board-armadillo800eva.c >> +++ b/arch/arm/mach-shmobile/board-armadillo800eva.c >> @@ -1040,9 +1040,9 @@ static struct asoc_simple_card_info fsi2_hdmi_info = { >> .card = "FSI2B-HDMI", >> .codec = "sh-mobile-hdmi", >> .platform = "sh_fsi2", >> + .daifmt = SND_SOC_DAIFMT_CBS_CFS, >> .cpu_dai = { >> .name = "fsib-dai", >> - .fmt = SND_SOC_DAIFMT_CBS_CFS, >> }, >> .codec_dai = { >> .name = "sh_mobile_hdmi-hifi", > > I guess if you want to use common .daifmt, it should be same as "codec" side. > (cpu side "S" means, codec / daifmt side "M") > So, this mean above should be > > @@ -1040,9 +1040,9 @@ static struct asoc_simple_card_info fsi2_hdmi_info = { > .card = "FSI2B-HDMI", > .codec = "sh-mobile-hdmi", > .platform = "sh_fsi2", > + .daifmt = SND_SOC_DAIFMT_CBM_CFM, <= > .cpu_dai = { > .name = "fsib-dai", > - .fmt = SND_SOC_DAIFMT_CBS_CFS, > }, Right now the CPU is configured as master, with your proposed change it would be configured as slave. These flags are always from the CODEC's perspective.