public inbox for alsa-devel@alsa-project.org
 help / color / mirror / Atom feed
From: Jaroslav Kysela <perex@perex.cz>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>, Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, clemens@ladisch.de
Subject: Re: [PATCH 6/8] ALSA: control: fix over 80 characters lines
Date: Thu, 12 Feb 2015 13:54:43 +0100	[thread overview]
Message-ID: <54DCA293.2030900@perex.cz> (raw)
In-Reply-To: <54DCA0EC.1010107@sakamocchi.jp>

Dne 12.2.2015 v 13:47 Takashi Sakamoto napsal(a):
> On Feb 11 2015 21:01, Takashi Iwai wrote:
>> At Wed, 11 Feb 2015 19:37:30 +0900,
>> Takashi Sakamoto wrote:
>>> @@ -1010,7 +1013,8 @@ struct user_element {
>>>  	unsigned int elem_data_size;	/* size of element data in bytes */
>>>  	void *tlv_data;			/* TLV data */
>>>  	unsigned long tlv_data_size;	/* TLV data size */
>>> -	void *priv_data;		/* private data (like strings for enumerated type) */
>>> +	/* private data (like strings for enumerated type) */
>>> +	void *priv_data;
>>
>> Better to put the comment in the same line like other fields.
> 
> Which do you mean, we allow this line over 80 characters (keep what it
> was), or I should revise this comment within 80 characters considering
> the authours idea?

Keep it as-is. Any change will make the readability more worse.

					Jaroslav

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Kernel Sound Maintainer
ALSA Project; Red Hat, Inc.

  reply	other threads:[~2015-02-12 12:54 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-11 10:37 [PATCH 0/8] ALSA: control: refactoring core codes Takashi Sakamoto
2015-02-11 10:37 ` [PATCH 1/8] ALSA: control: change type from long due to the definition of sizeof operator Takashi Sakamoto
2015-02-11 11:53   ` Takashi Iwai
2015-02-11 10:37 ` [PATCH 2/8] ALSA: control: obsolete switch statement with const value table Takashi Sakamoto
2015-02-11 10:51   ` Lars-Peter Clausen
2015-02-11 11:27     ` Takashi Sakamoto
2015-02-11 10:37 ` [PATCH 3/8] ALSA: control: gathering evaluations to access Takashi Sakamoto
2015-02-11 10:37 ` [PATCH 4/8] ALSA: control: add a comment about locking values after creating Takashi Sakamoto
2015-02-11 10:37 ` [PATCH 5/8] ALSA: control: rename loop index to i Takashi Sakamoto
2015-02-11 11:55   ` Takashi Iwai
2015-02-12 12:50     ` Takashi Sakamoto
2015-02-11 10:37 ` [PATCH 6/8] ALSA: control: fix over 80 characters lines Takashi Sakamoto
2015-02-11 12:01   ` Takashi Iwai
2015-02-12 12:47     ` Takashi Sakamoto
2015-02-12 12:54       ` Jaroslav Kysela [this message]
2015-02-11 10:37 ` [PATCH 7/8] ALSA: control: rename to appropriate macro name Takashi Sakamoto
2015-02-11 10:37 ` [PATCH 8/8] ALSA: control: arrange snd_ctl_new() as a local function Takashi Sakamoto
2015-02-11 12:49   ` Lars-Peter Clausen
2015-02-11 13:04     ` Takashi Iwai
2015-02-12 12:45       ` Takashi Sakamoto
2015-02-12 12:57         ` Takashi Iwai
2015-02-11 13:19 ` [PATCH 0/8] ALSA: control: refactoring core codes Takashi Iwai
2015-02-12 12:38   ` Takashi Sakamoto
2015-03-05 15:43 ` [PATCH 0/2][RFC] ALSA: core: optimizations for creating new controls Takashi Sakamoto
2015-03-05 15:43   ` [PATCH 1/2] ALSA: core: use precomputed table to check userspace control params Takashi Sakamoto
2015-03-05 15:43   ` [PATCH 2/2] ALSA: core: reduce stack usage related to snd_ctl_new() Takashi Sakamoto
2015-03-05 15:58   ` [PATCH 0/2][RFC] ALSA: core: optimizations for creating new controls Takashi Iwai
2015-03-07  4:57     ` Takashi Sakamoto
2015-03-10 13:13   ` [PATCH 0/2 v2] " Takashi Sakamoto
2015-03-10 13:13     ` [PATCH 1/2] ALSA: core: use precomputed table to check userspace control params Takashi Sakamoto
2015-03-10 13:13     ` [PATCH 2/2] ALSA: core: reduce stack usage related to snd_ctl_new() Takashi Sakamoto
2015-03-10 14:44     ` [PATCH 0/2 v2] ALSA: core: optimizations for creating new controls Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DCA293.2030900@perex.cz \
    --to=perex@perex.cz \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=o-takashi@sakamocchi.jp \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox