From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Sakamoto Subject: Re: [PATCH 3/5] ALSA: control: fix logic error about control count in a device Date: Thu, 12 Feb 2015 22:20:48 +0900 Message-ID: <54DCA8B0.1050306@sakamocchi.jp> References: <1423651213-19829-1-git-send-email-o-takashi@sakamocchi.jp> <1423651213-19829-4-git-send-email-o-takashi@sakamocchi.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtp302.phy.lolipop.jp (smtp302.phy.lolipop.jp [210.157.22.85]) by alsa0.perex.cz (Postfix) with ESMTP id 1989026525F for ; Thu, 12 Feb 2015 14:20:51 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org, clemens@ladisch.de List-Id: alsa-devel@alsa-project.org T24gMjAxNeW5tDAy5pyIMTHml6UgMjI6MTUsIFRha2FzaGkgSXdhaSB3cm90ZToKPiBBdCBXZWQs IDExIEZlYiAyMDE1IDE5OjQwOjExICswOTAwLAo+IFRha2FzaGkgU2FrYW1vdG8gd3JvdGU6Cj4+ Cj4+IEl0J3MgYXNzdW1lZCB0aGF0IHRoZSBudW1iZXIgb2YgdXNlcnNwYWNlIGNvbnRyb2xzIGlz IGp1c3QgMSBpbiBzZXZlcmFsCj4+IHBhcnRzLCB3aGlsZSB0aGlzIGFzc3VtcHRpb25zIGlzIG5v dCBhbHdheXMgdHJ1ZSBiZWNhdXNlIHRoZSB2YWx1ZSBvZgo+PiAnb3duZXInIG1lbWJlciBjYW4g YmUgYXNzaWduZWQgdG8uCj4+Cj4+IFRoaXMgY29tbWl0IGZpeGVzIHRoaXMgaXNzdWUuCj4gCj4g V2VsbCwgdGhlIGN1cnJlbnQgY29kZSBpc24ndCBpbmNvcnJlY3QsIGl0IGRlYWxzIHdpdGggdGhl IG51bWJlciBvZgo+IGdyb3VwZWQgZWxlbWVudHMsIG5vdCB0aGUgdG90YWwgbnVtYmVyIG9mIGVs ZW1lbnRzLgoKSSBkaWRuJ3QgcmVhZCBzdWNoIGRlc2lnbiBmcm9tIHRoZXNlIGNvbW1lbnRzLgoK aW5jbHVkZS9zb3VuZC9jb3JlLmg6CnN0cnVjdCBzbmRfY2FyZCB7Ci4uLgogICAgaW50IGNvbnRy b2xzX2NvdW50OyAgICAgICAgICAgICAvKiBjb3VudCBvZiBhbGwgY29udHJvbHMgKi8KICAgIGlu dCB1c2VyX2N0bF9jb3VudDsgICAgICAgICAgICAgLyogY291bnQgb2YgYWxsIHVzZXIgY29udHJv bHMgKi8KfX19CgpCdXQgJzMyJyBpcyBhIGJpdCBsaXR0bGUgYXMgbWF4aW11bSBudW1iZXIgb2Yg dXNlcnNwYWNlIGNvbnRyb2xzLCBzbwp5b3VyIGV4cGxhaW5hdGlvbiBtYXkgYmUgdHJ1ZS4gSWYg c28sIHRoZSBjb21tZW50IHNob3VsZCBiZSAnY291bnQgb2YKdXNlciBjb250cm9sIGdyb3Vwcycs IGF0IGxlYXN0LCBkaWZmZXJlbnQgZXhwcmVzc2lvbiBzaG91bGQgYmUgdXNlZC4KCj4gU28sIHRo aXMgaXMgcmF0aGVyIGEgY2hhbmdlIG9mIHRoZSBzZW1hbnRpY3Mgb2YgY2FyZC0+dXNlcl9jdGxf Y291bnQKPiBmaWVsZCB0aGFuIGEgZml4LCBhbmQgaXQncyB0aGUgcXVlc3Rpb246IHdoZXRoZXIg d2Ugc2hvdWxkIGxpbWl0IGZvcgo+IHRoZSB3aG9sZSBudW1iZXIgb2YgZWxlbWVudHMuCgpXZSBz aG91bGQgYXNzdW1lIHRoYXQgdXNlcnNwYWNlIGFwcGxpY2F0aW9ucyBpbmNsdWRlIGFueSBidWdz LiBUaGVyZSBtYXkKYmUgYW4gYXBwbGljYXRpb24gd2hpY2ggYWRkcyB0b28gbWFueSBjb250cm9s cy4gSW4gdGhpcyByZWFzb24sIHdlCnNob3VsZCBsaW1pdCB0aGUgbWF4aW11bSBudW1iZXIgb2Yg ZWxlbWVudHMuCgo+IFRoZXJlIGlzIGEgdmVyeSBzbGlnaHQgY2hhbmNlIG9mIHVzZXItc3BhY2Ug YnJlYWthZ2UgYnkgY291bnRpbmcgdGhlCj4gd2hvbGUgbnVtYmVycywgYnV0IHByYWdtYXRpY2Fs bHkgc2VlbiwgSSB0aGluayBpdCdzIGFjY2VwdGFibGUgZnJvbQo+IHRoZSBzYWZldHkgUE9WLgoK S2VybmVsIGRyaXZlcnMgZG9uJ3QgYWRkIHNvIG1hbnkgY29udHJvbHMsIHRodXMgc3VjaCBicmVh a2FnZSBpcyBjYXVzZWQKYnkgdXNlcnNwYWNlIGFwcGxpY2F0aW9ucy4gQnV0IEkgY2Fubm90IGlt YWdpbmUgc3VjaCBicmVha2FnZS4gSG93IGl0Cm9jY3Vycz8KCj4gSG93ZXZlciwgY2hhbmdpbmcg dGhlIGVycm9yIGNvZGUgaXMgbm8tZ28uCgpUaGlzIGlzIG15IGZhdWx0IHRvIGNyZWF0ZSB0aGlz IHBhdGNoc2V0Li4uCgoKVGhhbmtzCgpUYWthc2hpIFNha2Ftb3RvCgo+PiBTaWduZWQtb2ZmLWJ5 OiBUYWthc2hpIFNha2Ftb3RvIDxvLXRha2FzaGlAc2FrYW1vY2NoaS5qcD4KPj4gLS0tCj4+ICBz b3VuZC9jb3JlL2NvbnRyb2wuYyB8IDE3ICsrKysrKysrKysrKy0tLS0tCj4+ICAxIGZpbGUgY2hh bmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBh L3NvdW5kL2NvcmUvY29udHJvbC5jIGIvc291bmQvY29yZS9jb250cm9sLmMKPj4gaW5kZXggMWVk ZDZjNS4uYmNlNDczMCAxMDA2NDQKPj4gLS0tIGEvc291bmQvY29yZS9jb250cm9sLmMKPj4gKysr IGIvc291bmQvY29yZS9jb250cm9sLmMKPj4gQEAgLTUxNCw2ICs1MTQsNyBAQCBzdGF0aWMgaW50 IHNuZF9jdGxfcmVtb3ZlX3VzZXJfY3RsKHN0cnVjdCBzbmRfY3RsX2ZpbGUgKiBmaWxlLAo+PiAg ewo+PiAgCXN0cnVjdCBzbmRfY2FyZCAqY2FyZCA9IGZpbGUtPmNhcmQ7Cj4+ICAJc3RydWN0IHNu ZF9rY29udHJvbCAqa2N0bDsKPj4gKwl1bnNpZ25lZCBpbnQgY291bnQ7Cj4+ICAJaW50IGksIHJl dDsKPj4gIAo+PiAgCWRvd25fd3JpdGUoJmNhcmQtPmNvbnRyb2xzX3J3c2VtKTsKPj4gQEAgLTUz MSwxMCArNTMyLDExIEBAIHN0YXRpYyBpbnQgc25kX2N0bF9yZW1vdmVfdXNlcl9jdGwoc3RydWN0 IHNuZF9jdGxfZmlsZSAqIGZpbGUsCj4+ICAJCQlyZXQgPSAtRUJVU1k7Cj4+ICAJCQlnb3RvIGVy cm9yOwo+PiAgCQl9Cj4+ICsJY291bnQgPSBrY3RsLT5jb3VudDsKPj4gIAlyZXQgPSBzbmRfY3Rs X3JlbW92ZShjYXJkLCBrY3RsKTsKPj4gIAlpZiAocmV0IDwgMCkKPj4gIAkJZ290byBlcnJvcjsK Pj4gLQljYXJkLT51c2VyX2N0bF9jb3VudC0tOwo+PiArCWNhcmQtPnVzZXJfY3RsX2NvdW50IC09 IGNvdW50Owo+PiAgZXJyb3I6Cj4+ICAJdXBfd3JpdGUoJmNhcmQtPmNvbnRyb2xzX3J3c2VtKTsK Pj4gIAlyZXR1cm4gcmV0Owo+PiBAQCAtMTIwMiwxMCArMTIwNCwxNSBAQCBzdGF0aWMgaW50IHNu ZF9jdGxfZWxlbV9hZGQoc3RydWN0IHNuZF9jdGxfZmlsZSAqZmlsZSwKPj4gIAkJCXJldHVybiBl cnI7Cj4+ICAJfQo+PiAgCj4+IC0JaWYgKGNhcmQtPnVzZXJfY3RsX2NvdW50ID49IE1BWF9VU0VS X0NPTlRST0xTKQo+PiAtCQlyZXR1cm4gLUVOT01FTTsKPj4gKwkvKgo+PiArCSAqIFRoZSBudW1i ZXIgb2YgY29udHJvbHMgd2l0aCB0aGUgc2FtZSBmZWF0dXJlLCBkaXN0aW5ndWlzaGVkIGJ5IGlu ZGV4Lgo+PiArCSAqLwo+PiArCWtjdGwuY291bnQgPSBpbmZvLT5vd25lcjsKPj4gKwlpZiAoa2N0 bC5jb3VudCA9PSAwKQo+PiArCQlrY3RsLmNvdW50ID0gMTsKPj4gKwlpZiAoY2FyZC0+dXNlcl9j dGxfY291bnQgKyBrY3RsLmNvdW50ID4gTUFYX1VTRVJfQ09OVFJPTFMpCj4+ICsJCXJldHVybiAt RU5PU1BDOwo+PiAgCj4+IC0Ja2N0bC5jb3VudCA9IGluZm8tPm93bmVyID8gaW5mby0+b3duZXIg OiAxOwo+PiAgCWlmIChpbmZvLT50eXBlID09IFNORFJWX0NUTF9FTEVNX1RZUEVfRU5VTUVSQVRF RCkKPj4gIAkJa2N0bC5pbmZvID0gc25kX2N0bF9lbGVtX3VzZXJfZW51bV9pbmZvOwo+PiAgCWVs c2UKPj4gQEAgLTEyNTksNyArMTI2Niw3IEBAIHN0YXRpYyBpbnQgc25kX2N0bF9lbGVtX2FkZChz dHJ1Y3Qgc25kX2N0bF9maWxlICpmaWxlLAo+PiAgCQlyZXR1cm4gZXJyOwo+PiAgCj4+ICAJZG93 bl93cml0ZSgmY2FyZC0+Y29udHJvbHNfcndzZW0pOwo+PiAtCWNhcmQtPnVzZXJfY3RsX2NvdW50 Kys7Cj4+ICsJY2FyZC0+dXNlcl9jdGxfY291bnQgKz0gX2tjdGwtPmNvdW50Owo+PiAgCXVwX3dy aXRlKCZjYXJkLT5jb250cm9sc19yd3NlbSk7Cj4+ICAKPj4gIAlyZXR1cm4gMDsKPj4gLS0gCj4+ IDIuMS4wCj4+Cj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpBbHNhLWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcK aHR0cDovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2 ZWwK