From mboxrd@z Thu Jan 1 00:00:00 1970 From: Qais Yousef Subject: Re: [ALSA-UTILS][PATCH] Add support for cplay and crecord Date: Wed, 4 Mar 2015 16:34:41 +0000 Message-ID: <54F73421.3000108@imgtec.com> References: <1425483360-1806-1-git-send-email-qais.yousef@imgtec.com> <20150304161013.GU2613@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mailapp01.imgtec.com (mailapp01.imgtec.com [195.59.15.196]) by alsa0.perex.cz (Postfix) with ESMTP id 85C9526510B for ; Wed, 4 Mar 2015 17:34:43 +0100 (CET) In-Reply-To: <20150304161013.GU2613@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Vinod Koul Cc: Takashi Iwai , alsa-devel@alsa-project.org, Mark Brown List-Id: alsa-devel@alsa-project.org On 03/04/2015 04:10 PM, Vinod Koul wrote: > On Wed, Mar 04, 2015 at 03:36:00PM +0000, Qais Yousef wrote: >> cplay and crecord use compress offload API to play and record compressed audio. >> >> They're based on cplay and crec from tinycompress library using LGPL license. >> >> For now cplay only supports playing mp3 files. >> >> Signed-off-by: Qais Yousef >> Cc: Takashi Iwai >> Cc: Vinod Koul >> Cc: Mark Brown >> --- >> I renamed crec to crecord also to match aplay and arecord, hopefully >> you don't mind Vinod. > No thats fine.. > >> This patch is dependent on my other patch that adds support for compress offload >> to alsa-lib. > And where is that, should have preceded this Hmm not sure what went wrong. I resent it. Seems I have some emailer issues as I had this problem before. Hopefully you received it now. >> I needed to include in cplay.c and crec.c >> but I couldn't find an example of any C file which directly includes >> The norm seems to be to just include . Do I need to >> redefine structs from to newly added ? >> seems to redefine structs from . > These are kernel headers and should be in your include path if you have > those installed >> I could only test cplay but have no means to test crecord at the moment. >> >> Makefile.am | 3 + >> configure.ac | 6 +- >> cplay/Makefile.am | 14 ++ >> cplay/cplay.c | 294 +++++++++++++++++++++++++++++++++++ >> cplay/crec.c | 449 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> cplay/tinymp3.h | 72 +++++++++ >> 6 files changed, 837 insertions(+), 1 deletion(-) >> create mode 100644 cplay/Makefile.am >> create mode 100644 cplay/cplay.c >> create mode 100644 cplay/crec.c >> create mode 100644 cplay/tinymp3.h > Okay here is where we need discussion on the future course. If we do this > then we end up in two code bases, something I would not encourage! > > On the other hand if we add the make file changes to tinycompress or if > required split this into two, lib and tools and then package lib part into > alsa-lib and players into tools, that way we can have single code base. That > was my intent behind ensuring that this is dual licensed. I'm not sure I follow you completely here. You mean keep cplay and crec in tinycompress with the dual licensing but only merge the lib part (which my other patch does) into alsa-lib? For me having this lib part into alsa-lib is the important bit. Moving crec and cplay to alsa-utils was something I thought would be useful but maybe not. Thanks, Qais > > Takashi, is that something we could achieve? I think last time we discussed > this topic you seemed okay with this, only thing was tinycompress lacks > proper make support which we can add >