From: Lars-Peter Clausen <lars@metafoo.de>
To: vishal.thanki@gmail.com, wharms@bfs.de
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
kernel-janitors@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: simple-card: Add a NULL pointer check in asoc_simple_card_dai_link_of
Date: Thu, 05 Mar 2015 13:03:32 +0100 [thread overview]
Message-ID: <54F84614.3020108@metafoo.de> (raw)
In-Reply-To: <CAC3a_SDWqGLsgUu8_mRYkW=Y+KHvWvAWjUYr4Ba3BrDBiP6nNA@mail.gmail.com>
On 03/05/2015 11:45 AM, Vishal Thanki wrote:
> I am new to kasprintf. I think we need to make sure of freeing memory
> allocated using kasprintf.
There is also devm_kasprintf().
But these are really two separate things. One thing is the missing NULL
check, which is a bug fix and is fixed by your patch. The other thing is the
conversion to kasprintf() which is a code cleanup and should be done in a
separate patch.
- Lars
next prev parent reply other threads:[~2015-03-05 12:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 13:29 [PATCH] ASoC: simple-card: Add a NULL pointer check in asoc_simple_card_dai_link_of Vishal Thanki
2015-03-03 14:25 ` Mark Brown
2015-03-04 20:29 ` walter harms
2015-03-05 10:45 ` Vishal Thanki
2015-03-05 12:03 ` Lars-Peter Clausen [this message]
2015-03-05 19:35 ` [alsa-devel] " walter harms
-- strict thread matches above, loose matches on Subject: below --
2015-03-03 13:14 Vishal Thanki
2015-03-03 13:18 ` [alsa-devel] " Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F84614.3020108@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=vishal.thanki@gmail.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox