From: SF Markus Elfring <elfring@users.sourceforge.net>
To: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Takashi Iwai <tiwai@suse.com>
Cc: kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/4] ASoC: twl4030: Use common error handling code in twl4030_get_pdata()
Date: Thu, 23 Nov 2017 22:10:16 +0100 [thread overview]
Message-ID: <54fbbfe9-ee59-c346-e22a-f059e1f2552f@users.sourceforge.net> (raw)
In-Reply-To: <d2edbce1-ffce-9c18-3f50-baa0cdfb0152@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 23 Nov 2017 21:35:28 +0100
Add a jump target so that a bit of exception handling can be better reused
in an if branch of this function.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
sound/soc/codecs/twl4030.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
index 90691701b082..a1f0b45c83ca 100644
--- a/sound/soc/codecs/twl4030.c
+++ b/sound/soc/codecs/twl4030.c
@@ -239,11 +239,11 @@ static struct twl4030_codec_data *twl4030_get_pdata(struct snd_soc_codec *codec)
pdata = devm_kzalloc(codec->dev,
sizeof(struct twl4030_codec_data),
GFP_KERNEL);
- if (!pdata) {
- of_node_put(twl4030_codec_node);
- return NULL;
- }
+ if (!pdata)
+ goto put_node;
+
twl4030_setup_pdata_of(pdata, twl4030_codec_node);
+put_node:
of_node_put(twl4030_codec_node);
}
--
2.15.0
next prev parent reply other threads:[~2017-11-23 21:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 21:07 [PATCH 0/4] ALSA SoC TWL4030: Adjustments for two function implementations SF Markus Elfring
2017-11-23 21:08 ` [PATCH 1/4] ASoC: twl4030: Delete an error message for a failed memory allocation in twl4030_get_pdata() SF Markus Elfring
2017-11-27 18:54 ` Applied "ASoC: twl4030: Delete an error message for a failed memory allocation in twl4030_get_pdata()" to the asoc tree Mark Brown
2017-11-23 21:10 ` SF Markus Elfring [this message]
2017-11-23 21:11 ` [PATCH 3/4] ASoC: twl4030: Improve a size determination in two functions SF Markus Elfring
2017-11-23 21:12 ` [PATCH 4/4] ASoC: twl4030: Delete an unnecessary variable initialisation in twl4030_get_pdata() SF Markus Elfring
2017-12-04 14:04 ` [PATCH 0/4] ALSA SoC TWL4030: Adjustments for two function implementations Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54fbbfe9-ee59-c346-e22a-f059e1f2552f@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).