Re: [PATCH 1/2] ASoC: cygnus-audio: adding device tree bindings

Mark Brown
2015-03-31T05:58:06Z

[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]

On Mon, Mar 30, 2015 at 08:16:23PM -0700, Scott Branden wrote:

> +SSP Subnode properties:
> +- dai-name: The name of the DAI registered with ASOC

ASoC.

Why is this in the DT - it sounds like this is just an internal
implementation detail for Linux, not a property of the hardware.

> +- mode: Controls if this port should be configured as I2S or TDM mode.
> + Valid values are: "tdm" or "i2s"
> +- tdm-bits-per-frame: only if mode is "tdm" then this property must set.
> + Valid values are (128/256/512)

We'd normally leave these up to the machine driver to set as they're
link wide things for system integration. The bits per frame in
particular looks like something that's not going to be fixed by the
hardware and could be varied at runtime.

> +- port-status: Controls if port is enabled or not
> + Valid values "enabled" or "disabled"

This sounds like it's replicating the DT standard status property?

> +- channel-group: Control grouping of serial port
> + Valid values are "2_0", "3_1", or "5_1"

What does this mean? It looks like it's setting the number of channels
which again seems like a runtime thing.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]