From: David Henningsson <david.henningsson@canonical.com>
To: "Jie, Yang" <yang.jie@intel.com>, Takashi Iwai <tiwai@suse.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"Girdwood, Liam R" <liam.r.girdwood@intel.com>
Subject: Re: [PATCH v4 0/5] ALSA: jack: Refactoring for jack kctls
Date: Wed, 08 Apr 2015 20:47:15 +0200 [thread overview]
Message-ID: <552577B3.1060808@canonical.com> (raw)
In-Reply-To: <E7B1D079BA13FB44A978CC8F69C7D6A90550C4BE@SHSMSX101.ccr.corp.intel.com>
On 2015-04-08 16:14, Jie, Yang wrote:
>> -----Original Message-----
>> From: Takashi Iwai [mailto:tiwai@suse.de]
>> Sent: Wednesday, April 08, 2015 5:22 PM
>> To: Jie, Yang
>> Cc: David Henningsson; alsa-devel@alsa-project.org; broonie@kernel.org;
>> Girdwood, Liam R
>> Subject: Re: [alsa-devel] [PATCH v4 0/5] ALSA: jack: Refactoring for jack kctls
>>
>> At Wed, 8 Apr 2015 09:18:10 +0000,
>> Jie, Yang wrote:
>>> OK, then it may make life easier. Hi Takashi, you agree with this?
>>> Do we need add those kctls to the HDA codec, or to hda_nid_item?
>>
>> It's been added in the local list to manage the kctls belonging to a codec more
>> easily. But if snd_hda_codec_free() and _reset() can remove them
>> gracefully, there is no big reason to keep tracking there.
>>
>
> I am not sure if snd_hda_codec_free() and _reset() can remove them, with
> removing tracking them in HDA codec in my current patch series. To be more
> simply and safely, I just keep this old tracking ATM, and we can add patch
> to optimize them later if needed, do you agree?
Is it possible for the snd_jack object to own its kctls, so when
snd_jack_dev_free is called, that would free the kctls too? Or at least
have some kind of flag that would allow snd_jack_free to also delete its
associated kctls?
(And then snd_hda_codec_reset/free would end up calling snd_jack_dev_free.)
--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
next prev parent reply other threads:[~2015-04-08 18:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 12:07 [PATCH v4 0/5] ALSA: jack: Refactoring for jack kctls Jie Yang
2015-04-03 12:07 ` [PATCH v4 1/5] ALSA: jack: create jack kcontrols for every jack input Jie Yang
2015-04-03 12:07 ` [PATCH v4 2/5] ALSA: jack: add a parameter to pass kctl for snd_jack_new Jie Yang
2015-04-03 12:07 ` [PATCH v4 3/5] ALSA: hda - Update to use the new jack kctls method Jie Yang
2015-04-03 12:07 ` [PATCH v4 4/5] ASoC: jack: create kctls according to jack pins info Jie Yang
2015-04-03 12:07 ` [PATCH v4 5/5] ALSA: jack: remove export snd_kctl_jack_new() Jie Yang
2015-04-06 16:11 ` [PATCH v4 0/5] ALSA: jack: Refactoring for jack kctls Mark Brown
2015-04-07 16:06 ` Takashi Iwai
2015-04-08 2:53 ` Jie, Yang
2015-04-08 4:39 ` Raymond Yau
2015-04-08 7:20 ` David Henningsson
2015-04-08 7:34 ` Takashi Iwai
2015-04-08 7:49 ` David Henningsson
2015-04-08 7:59 ` Jie, Yang
2015-04-08 8:27 ` David Henningsson
2015-04-08 9:18 ` Jie, Yang
2015-04-08 9:22 ` Takashi Iwai
2015-04-08 14:14 ` Jie, Yang
2015-04-08 14:29 ` Takashi Iwai
2015-04-08 18:47 ` David Henningsson [this message]
2015-04-08 18:55 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552577B3.1060808@canonical.com \
--to=david.henningsson@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@intel.com \
--cc=tiwai@suse.de \
--cc=yang.jie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox