Re: [PATCH] ASoC: at91sam9g20ek: Automatically disconnect non-connected pins

[Lars-Peter Clausen <lars@metafoo.de>]

On 04/13/2015 10:53 AM, Nicolas Ferre wrote:
> Le 11/04/2015 11:18, Lars-Peter Clausen a écrit :
>> According to the schematics the both LHPOUT and RHPOUT are connected to the
>> external connector. RHPOUT is missing from the DAPM routes, but otherwise
>> they seem to be complete.
>>
>> This patch adds the missing route and then sets the fully_routed flag for
>> the card. This allows to remove all the manual calls to
>> snd_soc_dapm_nc_pin().
>
> I don't understand: on the schematics, both the "RLINEIN" and "LLINEIN"
> are actually not connected. So, why remove these calls to
> snd_soc_dapm_nc_pin(). Note also that "ROUT" and "LOUT" signals are not
> connected as well.
>

For legacy reasons by default a INPUT or OUTPUT pin is considered connected 
unless explicitly marked as non-connected. When the fully_routed flag is set 
INPUT and OUTPUT pins are considered to be not connected unless explicitly 
connected. What the patch does is set the fully_routed flag and remove the 
explicit calls to snd_soc_dapm_nc_pin() since the pins are now considered to 
be non-connected by default.

- Lars