From: Jyri Sarha <jsarha@ti.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Ujfalusi, Peter" <peter.ujfalusi@ti.com>,
alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>
Subject: Re: ASoC: davinci-mcasp: Set rule constraints if implicit BCLK divider is used
Date: Mon, 13 Apr 2015 16:32:24 +0300 [thread overview]
Message-ID: <552BC568.7070907@ti.com> (raw)
In-Reply-To: <20150413121639.GU16501@mwanda>
On 04/13/15 15:16, Dan Carpenter wrote:
> Thanks for looking at this. I haven't double checked your analysis, but
> 512 means the stack is 2k and that's too high. I think there is
> supposed to be a build warning if we use more than 1k of stack in a
> function?
>
> It's better to allocate it with kmalloc() and free it at the end.
>
> regards,
> dan carpenter
>
The function may get called hundreds or even thousands of times when an
audio stream is started. How heavy is kmalloc/free cycle?
Using kmalloc just feels a bit stupid since in any remotely feasible
case the maximum number of channels is 8. But maybe I just should not care.
Best regards,
Jyri
next prev parent reply other threads:[~2015-04-13 13:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 9:33 ASoC: davinci-mcasp: Set rule constraints if implicit BCLK divider is used Dan Carpenter
2015-04-13 11:39 ` Jyri Sarha
2015-04-13 12:16 ` Dan Carpenter
2015-04-13 13:32 ` Jyri Sarha [this message]
2015-04-13 13:58 ` Dan Carpenter
2015-04-13 14:22 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2015-03-27 6:20 Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552BC568.7070907@ti.com \
--to=jsarha@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox