From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jyri Sarha Subject: Re: [PATCH 0/2] Calculate BCLK using TDM slots and remove channels rule Date: Wed, 22 Apr 2015 10:44:11 +0300 Message-ID: <5537514B.1040807@ti.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by alsa0.perex.cz (Postfix) with ESMTP id F16FA260525 for ; Wed, 22 Apr 2015 09:44:17 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: alsa-devel@alsa-project.org Cc: liam.r.girdwood@linux.intel.com, peter.ujfalusi@ti.com, misael.lopez@ti.com, broonie@kernel.org, dan.carpenter@oracle.com List-Id: alsa-devel@alsa-project.org There still something fishy with multi channel multi serializer case, so please don't take these patches yet. Best regards, Jyri On 04/20/15 16:58, Jyri Sarha wrote: > The first patch is a bugfix. I did not have the HW see the problem > myself, but reading from the code the problem is evident. This should > also fix Dan Carpenter's concern about stack usage in > davinci_mcasp_hw_rule_channels(), as the whole function is removed. > > The second patch is just an optimization of the sample-rate rule. In > effect I put in use Takashi Iwai's suggestion for fixing the stack > usage issue in the channels rule. > > Jyri Sarha (2): > ASoC: davinci-mcasp: Calculate BCLK using TDM slots and remove > channels rule > ASoC: davinci-macsp: Optimize implicit BLCK sample-rate rule > > sound/soc/davinci/davinci-mcasp.c | 104 ++++++++++---------------------------- > 1 file changed, 27 insertions(+), 77 deletions(-) >