Re: [PATCH 2/4] ASoC: rockchip: add rockchip machine driver for max98090

Mark Brown
2015-05-13T16:47:38Z

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]

On Wed, May 13, 2015 at 09:23:20PM +0800, zhengxing wrote:
> On 2015年05月13日 03:26, Mark Brown wrote:

> >This looks more like a normal and reasonable machine driver but then why
> >have you created the generic rockchip machine driver? It seems like
> >this should just be a regular machine driver like other platforms have,
> >were it not for that this would be mostly fine apart from a couple of
> >nitpicks below.

> We just use rockchip_machine_driver to describe the supported codecs base on
> origianl way, vendor machine driver(rockchip_max98090) will achieve
> functions.

Like I said in reply to the other message I just don't understand what
you're saying here - take a look at the various Tegra machine drivers
for example, they also have per-CODEC handling but they just use normal
machine drivers to do it.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]