From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH] ASoC: codecs-ac97: make selectable in config Date: Thu, 14 May 2015 21:24:15 +0200 Message-ID: <5554F65F.7090004@metafoo.de> References: <554E8634.2010008@maciej.szmigiero.name> <20150512175807.GL3066@sirena.org.uk> <5553BAB4.3040209@maciej.szmigiero.name> <20150514175351.GQ2761@sirena.org.uk> <5554ED71.4040608@metafoo.de> <20150514191031.GS2761@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150514191031.GS2761@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: "Maciej S. Szmigiero" , alsa-devel@alsa-project.org, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Brian Austin , Bard Liao , Oder Chiou , Wolfram Sang , linux-kernel@vger.kernel.org, Fabio Estevam List-Id: alsa-devel@alsa-project.org On 05/14/2015 09:10 PM, Mark Brown wrote: > On Thu, May 14, 2015 at 08:46:09PM +0200, Lars-Peter Clausen wrote: >> On 05/14/2015 07:53 PM, Mark Brown wrote: > >>> select doesn't respect dependencies, it'll just force on the selected >>> symbol. > >> The patch works fine, neither SND_SOC_AC97_BUS nor the symbols selected by >> SND_SOC_AC97_BUS have any dependencies. > > Does the select from SND_SOC_AC97_BUS actually happen if it is selected > by SND_SOC_ALL_CODECS? That's the issue, if it works now it's a > relatively recent thing. I'm not sure I fully understand what you mean. The Kconfig entry for the CODEC has no 'depends on'. It does a 'select SND_SOC_AC97_BUS', which means all built time dependencies are pulled in this way. So if SND_SOC_ALL_CODECS selects the CODEC unconditionally that should work fine, since no dependencies are bypassed.