From: Clemens Ladisch <clemens@ladisch.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>, Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 0/4] ALSA: firewire-lib: code cleanup
Date: Sat, 23 May 2015 21:16:23 +0200 [thread overview]
Message-ID: <5560D207.3010404@ladisch.de> (raw)
In-Reply-To: <1432304474-6533-1-git-send-email-o-takashi@sakamocchi.jp>
Takashi Sakamoto wrote:
> Current implementation includes several macros and functions with improper
> name, hard-coded numerical value and so on.
>
> This patchset is for code cleanup.
>
> Takashi Sakamoto (4):
> ALSA: firewire-lib: rename local functions for code cleanup
> ALSA: firewire-lib: macro arrangement for code cleanup
> ALSA: firewire-lib: use dev_err() when detecting incoming streaming error
> ALSA: firewire-lib: use protocol error when detecting wrong value in CIP header
All four:
Acked-by: Clemens Ladisch <clemens@ladisch.de>
> sound/firewire/amdtp.c | 104 ++++++++++++++++++++++++++-----------------------
> 1 file changed, 55 insertions(+), 49 deletions(-)
next prev parent reply other threads:[~2015-05-23 19:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 14:21 [PATCH 0/4] ALSA: firewire-lib: code cleanup Takashi Sakamoto
2015-05-22 14:21 ` [PATCH 1/4] ALSA: firewire-lib: rename local functions for " Takashi Sakamoto
2015-05-22 14:21 ` [PATCH 2/4] ALSA: firewire-lib: macro arrangement " Takashi Sakamoto
2015-05-22 14:21 ` [PATCH 3/4] ALSA: firewire-lib: use dev_err() when detecting incoming streaming error Takashi Sakamoto
2015-05-22 15:08 ` Takashi Iwai
2015-05-22 18:05 ` Clemens Ladisch
2015-05-23 4:16 ` Takashi Sakamoto
2015-05-23 7:00 ` Takashi Sakamoto
2015-05-22 14:21 ` [PATCH 4/4] ALSA: firewire-lib: use protocol error when detecting wrong value in CIP header Takashi Sakamoto
2015-05-23 19:16 ` Clemens Ladisch [this message]
2015-05-24 6:35 ` [PATCH 0/4] ALSA: firewire-lib: code cleanup Takashi Iwai
2015-05-24 11:41 ` Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5560D207.3010404@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=o-takashi@sakamocchi.jp \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox