From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Subject: Re: [RESEND PATCH v1 2/2] drm: bridge/dw_hdmi-i2s-audio: add audio driver Date: Mon, 25 May 2015 17:38:48 +0800 Message-ID: <5562EDA8.1000609@rock-chips.com> References: <1432307631-7667-1-git-send-email-ykk@rock-chips.com> <1432307696-7806-1-git-send-email-ykk@rock-chips.com> <1432542247.27695.137.camel@x220> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1432542247.27695.137.camel@x220> Sender: linux-kernel-owner@vger.kernel.org To: Paul Bolle Cc: alsa-devel , dri-devel , linux-arm-kernel , Mark Brown , Takashi Iwai , Fabio Estevam , Russell King , Thierry Reding , Philipp Zabel , linux-kernel@vger.kernel.org, Inki Dae , Andy Yan , David Airlie , Greg Kroah-Hartman , Ajay Kumar , Dave Airlie List-Id: alsa-devel@alsa-project.org Hi Paul, =E5=9C=A8 2015/5/25 16:24, Paul Bolle =E5=86=99=E9=81=93: > Just a nit: a license mismatch. > > On Fri, 2015-05-22 at 10:14 -0500, Yakir Yang wrote: >> --- /dev/null >> +++ b/drivers/gpu/drm/bridge/dw_hdmi-i2s-audio.c >> + * This program is free software; you can redistribute it and/or mo= dify >> + * it under the terms of the GNU General Public License version 2 a= s >> + * published by the Free Software Foundation. > This states the license is GPL v2. > >> +MODULE_LICENSE("GPL"); > And, according to include/linux/module.h, this states the license is = GPL > v2 or later. So I think that either the comment at the top of this fi= le > or the ident used in the MODULE_LICENSE() macro should change. Thanks for your catch, got it :-) Yakir Yang > > Paul Bolle > > > >