From: Lars-Peter Clausen <lars@metafoo.de>
To: Dylan Reid <dgreid@chromium.org>, alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org, lgirdwood@gmail.com,
zhengxing@rock-chips.com
Subject: Re: [RFC 0/5] Add a gpio jack device
Date: Mon, 25 May 2015 17:17:01 +0200 [thread overview]
Message-ID: <55633CED.2090600@metafoo.de> (raw)
In-Reply-To: <1432332563-15447-1-git-send-email-dgreid@chromium.org>
On 05/23/2015 12:09 AM, Dylan Reid wrote:
> The first three changes add a gpio audio jack device. This device can
> be used on systems that report headphone or mic plug through GPIOS.
> There can be 0-N of these devices created per board each can report one
> of several events. For example, this allows for a single jack for
> HP/Mic and a separate jack for line out.
I'm not convinced that this series is the right approach and I don't think
it helps us to solve the problem.
I think what we need to get the layering and encapsulation right is to
introduce a distinction between jacks and jack detection logic. The jacks
are part of the fabric and should be registered by the machine driver. The
jack detection logic can be implemented by either GPIOs, a dedicated jack
detection chip, like the TS3A227E, or can be part of a more complex CODEC.
The jack detection logic is a function that is provided by these. The audio
fabric, which makes up the sound card, is a consumer of this functionality.
To be able to properly abstract this changes to the framework are necessary
to introduce the concept of jack detection logic providers and consumers.
The chip/driver that implements the jack detection logic register a jack
detection logic provider, the machine driver registers the jack and
specifies which jack detection provider is used for each jack.
- Lars
next prev parent reply other threads:[~2015-05-25 15:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 22:09 [RFC 0/5] Add a gpio jack device Dylan Reid
2015-05-22 22:09 ` [RFC 1/5] ALSA: Add jack types to dt-bindings Dylan Reid
2015-05-25 12:11 ` Mark Brown
2015-05-22 22:09 ` [RFC 2/5] ASoC: jack - add_gpiods accepts filled descriptors Dylan Reid
2015-05-25 12:12 ` Mark Brown
2015-05-22 22:09 ` [RFC 3/5] ASoC: Add GPIO based jack device Dylan Reid
2015-05-25 12:11 ` Mark Brown
2015-05-26 6:20 ` Dylan Reid
2015-05-22 22:09 ` [RFC 4/5] ASoC: tegra_max98090: Change nyan to use gpio-jack Dylan Reid
2015-05-22 22:09 ` [RFC 5/5] ARM: tegra: nyan: specify gpio-audio-jack device Dylan Reid
2015-05-25 15:17 ` Lars-Peter Clausen [this message]
2015-05-25 17:15 ` [RFC 0/5] Add a gpio jack device Mark Brown
2015-05-25 18:58 ` Dylan Reid
2015-05-26 18:43 ` Lars-Peter Clausen
2015-05-26 20:14 ` Mark Brown
2015-05-27 4:22 ` Dylan Reid
2015-05-27 11:15 ` Lars-Peter Clausen
2015-05-27 17:26 ` Mark Brown
2015-05-28 5:38 ` Dylan Reid
2015-05-28 10:17 ` Mark Brown
2015-05-27 11:12 ` Lars-Peter Clausen
2015-05-28 19:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55633CED.2090600@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dgreid@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.de \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox