From: Sergej Sawazki <ce3a@gmx.de>
To: lgirdwood@gmail.com, Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org
Subject: ASoC: codec register dump in debugfs
Date: Fri, 29 May 2015 09:16:56 +0200 [thread overview]
Message-ID: <55681268.1050508@gmx.de> (raw)
Dear all,
please correct me if I am wrong. Since the codec drivers have been
converted to direct regmap API usage, it is not common to set the
following snd_soc_codec_driver struct members:
.reg_cache_size
.reg_word_size
However, the functions soc_codec_reg_show() and format_register_str()
(responsible for formating and printing the codec register dumps to
debugfs) depend on these members.
I'm writing a ASoC machine driver. The board has two wm8741 codecs.
I would like to see the codec register dumps in debugfs.
eg:
cat /sys/kernel/debug/asoc/<card_name>/codec\:wm8741.1-001a/codec_reg
cat /sys/kernel/debug/asoc/<card_name>/codec\:wm8741.1-001b/codec_reg
Is it OK to set the above mentioned members in a codec driver to
"enable" the register dump output?
Or should we refactor the above mentioned functions to use the regmap
API?
Or am I missing something?
Thanks,
Sergej
next reply other threads:[~2015-05-29 7:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 7:16 Sergej Sawazki [this message]
2015-05-29 9:04 ` ASoC: codec register dump in debugfs Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55681268.1050508@gmx.de \
--to=ce3a@gmx.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox