From: Lars-Peter Clausen <lars@metafoo.de>
To: Bard Liao <bardliao@realtek.com>,
broonie@kernel.org, lgirdwood@gmail.com
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
zhengxing@rock-chips.com, yang.a.fang@intel.com,
koro.chen@mediatek.com, john.lin@realtek.com,
Leilk.Liu@mediatek.com, flove@realtek.com
Subject: Re: [PATCH v2 2/2] ASoC: rt5645: add device tree support
Date: Fri, 29 May 2015 18:31:55 +0200 [thread overview]
Message-ID: <5568947B.3040309@metafoo.de> (raw)
In-Reply-To: <1432894607-28489-2-git-send-email-bardliao@realtek.com>
On 05/29/2015 12:16 PM, Bard Liao wrote:
[...]
> +
> +Example:
> +
> +codec: rt5650@1a {
> + compatible = "realtek,rt5650";
> + reg = <0x1a>;
> + rt5645-gpios = <&gpio 19 0>;
The gpio is missing from the property documentation.
> + interrupt-parent = <&gpio>;
> + interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
> + realtek,dmic-en = "true";
> + realtek,en-jd-func = "true";
> + realtek,jd-mode = <3>;
> +};
next prev parent reply other threads:[~2015-05-29 16:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 10:16 [PATCH v2 1/2] ASoC: rt5645: change gpio to gpiod APIs Bard Liao
2015-05-29 10:16 ` [PATCH v2 2/2] ASoC: rt5645: add device tree support Bard Liao
2015-05-29 16:31 ` Lars-Peter Clausen [this message]
2015-05-29 14:23 ` [PATCH v2 1/2] ASoC: rt5645: change gpio to gpiod APIs Michele Curti
2015-05-29 16:31 ` Lars-Peter Clausen
2015-06-02 17:16 ` Mark Brown
2015-06-03 12:03 ` Bard Liao
2015-06-03 12:08 ` Lars-Peter Clausen
2015-06-03 12:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5568947B.3040309@metafoo.de \
--to=lars@metafoo.de \
--cc=Leilk.Liu@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=flove@realtek.com \
--cc=john.lin@realtek.com \
--cc=koro.chen@mediatek.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=yang.a.fang@intel.com \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).