From: Jack Mitchell <ml@embed.me.uk>
To: alsa-devel@alsa-project.org
Subject: simple-audio-card with omap4-dmic
Date: Wed, 03 Jun 2015 16:37:02 +0100 [thread overview]
Message-ID: <556F1F1E.8040405@embed.me.uk> (raw)
I'm currently working with a PandaBoard clone (OMAP44xx) which doesn't
have the usual twl6040 codec, however I would like to attach a digital
microphone directly into the OMAP.
I have added the following to my device tree:
sound {
compatible = "simple-audio-card";
simple-audio-card,name = "dmic-card";
simple-audio-card,format = "pdm";
status = "okay";
simple-audio-card,dai-link@0 {
cpu {
sound-dai = <&dmic>;
};
codec {
sound-dai = <&dmic_codec>;
};
};
};
dmic_codec: dmic_codec {
#sound-dai-cells = <0>;
compatible = "linux,dmic-codec";
};
and created a small patch to allow the generic dmic-hifi codec to be
instantiated from device tree.
diff --git a/sound/soc/codecs/dmic.c b/sound/soc/codecs/dmic.c
index fde5325..67b9198 100644
--- a/sound/soc/codecs/dmic.c
+++ b/sound/soc/codecs/dmic.c
@@ -69,11 +69,18 @@ static int dmic_dev_remove(struct platform_device *pdev)
return 0;
}
-MODULE_ALIAS("platform:dmic-codec");
+#ifdef CONFIG_OF
+static const struct of_device_id dmic_dt_ids[] = {
+ { .compatible = "linux,dmic-codec", },
+ { }
+};
+MODULE_DEVICE_TABLE(of, dmic_dt_ids);
+#endif
static struct platform_driver dmic_driver = {
.driver = {
.name = "dmic-codec",
+ .of_match_table = of_match_ptr(dmic_dt_ids),
},
.probe = dmic_dev_probe,
.remove = dmic_dev_remove,
@@ -81,6 +88,7 @@ static struct platform_driver dmic_driver = {
module_platform_driver(dmic_driver);
+MODULE_ALIAS("platform:dmic-codec");
MODULE_DESCRIPTION("Generic DMIC driver");
MODULE_AUTHOR("Liam Girdwood <lrg@slimlogic.co.uk>");
MODULE_LICENSE("GPL");
However, no soundcards get loaded, and I don't get error or warnings in
dmesg, so I'm at a bit of a loss at where I'm going wrong. Can anybody
see any glaring mistakes? I know the driver is definitely getting loaded
as I have seen errors relating to me not specifying the sound-dai-cells
from the simple-audio-card driver.
Any ideas would be greatly recieved!
Cheers,
next reply other threads:[~2015-06-03 15:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 15:37 Jack Mitchell [this message]
2015-06-03 16:39 ` simple-audio-card with omap4-dmic Jack Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556F1F1E.8040405@embed.me.uk \
--to=ml@embed.me.uk \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox