From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: Lars-Peter Clausen <lars@metafoo.de>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: rx51: Automatically disconnect non-connected pins
Date: Sun, 07 Jun 2015 16:58:27 +0300 [thread overview]
Message-ID: <55744E03.3000006@bitmer.com> (raw)
In-Reply-To: <1433427231-21756-1-git-send-email-lars@metafoo.de>
On 06/04/2015 05:13 PM, Lars-Peter Clausen wrote:
> According to the schematics the external speaker is differential, so the
> HPLCOM and HPRCOM pins of the CODEC should be connected to it.
>
> Otherwise the routing looks complete, so add the missing routes and set the
> fully_routed flag of the card instead of manually marking the unused inputs
> and outputs as not connected. This makes the code a bit shorter and
> cleaner.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> sound/soc/omap/rx51.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
Tested-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
next prev parent reply other threads:[~2015-06-07 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 14:13 [PATCH] ASoC: rx51: Automatically disconnect non-connected pins Lars-Peter Clausen
2015-06-07 13:58 ` Jarkko Nikula [this message]
2015-06-08 6:41 ` Peter Ujfalusi
2015-06-09 17:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55744E03.3000006@bitmer.com \
--to=jarkko.nikula@bitmer.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox