Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: David Henningsson <david.henningsson@canonical.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: "Yang, Libin" <libin.yang@intel.com>,
	"Lin, Mengdong" <mengdong.lin@intel.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 1/2] ALSA: hda - Continue probing even if i915 binding fails
Date: Fri, 12 Jun 2015 16:33:32 +0200	[thread overview]
Message-ID: <557AEDBC.8060305@canonical.com> (raw)
In-Reply-To: <s5hioathv3l.wl-tiwai@suse.de>



On 2015-06-12 16:14, Takashi Iwai wrote:
> At Fri, 12 Jun 2015 08:37:38 +0200,
> Takashi Iwai wrote:
>>
>> At Fri, 12 Jun 2015 08:17:12 +0200,
>> David Henningsson wrote:
>>> If BIOS disables the power well, then we would get the "audio register
>>> I/O error" in the boot phase, there will be no codecs detected, and thus
>>> no broken sound card showing up.
>>>
>>> The only issue is if the i915 driver disables the power well, but the
>>> case that the i915 should be functioning enough to turn off the power
>>> well at some point, and at the same time so broken that we can't bind to
>>> it, seems extremely unlikely to me.
>>>
>>> Either the i915 driver works, or it does not. In both cases, continuing
>>> probing is the more useful option.
>>
>> I don't see much usefulness there but rather simplicity.
>>
>> The binding with i915 won't happen at the later stage, thus the device
>> is just a placeholder.  Any other goodies by keeping the dead device?
>>
>>>> Fair enough.  Then I'm going to queue the patch below in addition to
>>>> for-linus branch.
>>>
>>> We'll have to agree to disagree on that, then.
>>
>> One point that hasn't been mentioned is the behavior change from the
>> previous kernels.  The previous kernels abort probing, and it was OK
>> since we supposed only HSW/BDW before 4.1.  Now, with continuing the
>> probe, user sees the new device that hasn't been there, and yet the
>> device is dead and merely a placeholder.
>
> Is this convincing enough for you?  Or would you still like to make
> the broken HDMI/DP device enabled for HSW/BDW?

I guess the question is whether HDMI/DP can actually work without the 
i915 driver, e g when running with nomodeset. If there is absolutely no 
possibility whatsoever (e g maybe BIOS could set up the device so that 
it works?), then it does not matter much, I suppose.

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic

  reply	other threads:[~2015-06-12 14:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-10 10:26 [PATCH 1/2] ALSA: hda - Continue probing even if i915 binding fails Takashi Iwai
2015-06-10 10:26 ` [PATCH 2/2] ALSA: hda - Allow calling snd_hdac_i915_*() without actual binding Takashi Iwai
2015-06-12  2:08 ` [PATCH 1/2] ALSA: hda - Continue probing even if i915 binding fails Lin, Mengdong
2015-06-12  5:08   ` Takashi Iwai
2015-06-12  5:50     ` Lin, Mengdong
2015-06-12  6:06       ` Takashi Iwai
2015-06-12  6:17         ` David Henningsson
2015-06-12  6:37           ` Takashi Iwai
2015-06-12 14:14             ` Takashi Iwai
2015-06-12 14:33               ` David Henningsson [this message]
2015-06-12 14:36                 ` Takashi Iwai
2015-06-12  6:51           ` Lin, Mengdong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=557AEDBC.8060305@canonical.com \
    --to=david.henningsson@canonical.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=libin.yang@intel.com \
    --cc=mengdong.lin@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox