From: Clemens Ladisch <clemens@ladisch.de>
To: Laurence Darby <ldarby@tuffmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: oxygen: Fix S/PDIF muting
Date: Sun, 28 Jun 2015 20:44:26 +0200 [thread overview]
Message-ID: <5590408A.6030100@ladisch.de> (raw)
In-Reply-To: <20150628131337.d8077aed73a9851b194bdc30@tuffmail.com>
Laurence Darby wrote:
> The S/PDIF output was muted whenever audio wasn't playing which resulted
> in a clicking noise from the DAC when resuming
It indeed appears that there are too many oxygen_clear_bits32() calls.
However, I don't trust the hardware; please confirm that the S/PDIF
output, without an active stream, play zeros and not the last sample.
> Also, the mixer control wasn't actually controlling the S/PDIF output.
Because that is not its purpose to begin with. >:-)
The mixer control enables copying the "Multichannel" device to the
S/PDIF output. The "Digital" device has no mute, and takes precedence
over the multichannel device when both are active.
Regards,
Clemens
next prev parent reply other threads:[~2015-06-28 18:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-28 12:13 [PATCH] ALSA: oxygen: Fix S/PDIF muting Laurence Darby
2015-06-28 18:44 ` Clemens Ladisch [this message]
2015-06-29 20:01 ` Laurence Darby
2015-06-30 9:43 ` Clemens Ladisch
2015-07-05 18:56 ` Laurence Darby
2015-07-05 19:23 ` Clemens Ladisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5590408A.6030100@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=ldarby@tuffmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox