From: Lars-Peter Clausen <lars@metafoo.de>
To: Raymond Yau <superquad.vortex2@gmail.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Takashi Iwai <tiwai@suse.de>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>
Subject: Re: [RFC PATCH 3/4] ALSA: core: add report of max dma burst
Date: Fri, 10 Jul 2015 19:13:45 +0200 [thread overview]
Message-ID: <559FFD49.6090104@metafoo.de> (raw)
In-Reply-To: <CAN8cciYf_oz+ozAesHu5j_V0=iDSuFrLM5E2i6f+CbaXqWX9uQ@mail.gmail.com>
On 07/10/2015 04:35 AM, Raymond Yau wrote:
[...]
> What is the usage of runtime->dma_bytes in
> snd_pcm_hw_constraints_complete() in core/pcm_native.c ?
>
> Was the usage similar to 128 bytes alignment ?
>
> /* FIXME: remove */
> if (runtime->dma_bytes) {
> err = snd_pcm_hw_constraint_minmax(runtime,
> SNDRV_PCM_HW_PARAM_BUFFER_BYTES, 0, runtime->dma_bytes);
> if (err < 0)
> return err;
> }
The FIXME is probably correct. dma_bytes should always be 0 at that point.
This is a freshly allocated runtime struct and dma_bytes only gets set once
a buffer is allocated, which is done later on.
- Lars
next prev parent reply other threads:[~2015-07-10 17:13 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 10:10 [RFC PATCH 0/4] better support for bursty DMA usages Pierre-Louis Bossart
2015-07-08 10:10 ` [RFC PATCH 1/4] ALSA: core: let low-level driver or userspace disable rewinds Pierre-Louis Bossart
2015-07-08 14:21 ` Takashi Iwai
2015-07-08 16:58 ` Pierre-Louis Bossart
2015-07-11 17:06 ` Alexander E. Patrakov
2015-07-14 3:32 ` Raymond Yau
2015-07-14 17:39 ` Alexander E. Patrakov
2015-07-15 1:23 ` Raymond Yau
2015-07-15 4:51 ` Alexander E. Patrakov
2015-07-28 14:19 ` Pierre-Louis Bossart
2015-07-28 15:43 ` Alexander E. Patrakov
2015-07-29 17:46 ` Pierre-Louis Bossart
2015-07-30 6:11 ` Alexander E. Patrakov
2015-07-30 13:46 ` Pierre-Louis Bossart
2015-07-08 10:10 ` [RFC PATCH 2/4] ALSA: core: add .notify callback for pcm ops Pierre-Louis Bossart
2015-07-08 14:27 ` Takashi Iwai
2015-07-08 17:10 ` Pierre-Louis Bossart
2015-07-09 14:44 ` Takashi Iwai
2015-07-09 7:25 ` Raymond Yau
2015-07-09 7:35 ` Pierre-Louis Bossart
2015-07-08 10:10 ` [RFC PATCH 3/4] ALSA: core: add report of max dma burst Pierre-Louis Bossart
2015-07-08 14:37 ` Takashi Iwai
2015-07-08 17:46 ` Pierre-Louis Bossart
2015-07-10 2:35 ` Raymond Yau
2015-07-10 17:13 ` Lars-Peter Clausen [this message]
2015-07-11 17:46 ` Alexander E. Patrakov
2015-07-11 18:28 ` Jaroslav Kysela
2015-07-16 2:11 ` Raymond Yau
2015-07-08 10:10 ` [RFC PATCH 4/4] ALSA: hda: add default value for max_dma_burst Pierre-Louis Bossart
2015-07-08 14:31 ` [RFC PATCH 0/4] better support for bursty DMA usages Takashi Iwai
2015-07-08 17:50 ` Pierre-Louis Bossart
2015-07-15 10:14 ` Raymond Yau
2015-07-15 10:38 ` Alexander E. Patrakov
2015-07-22 14:44 ` Raymond Yau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559FFD49.6090104@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=superquad.vortex2@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox