From: Lars-Peter Clausen <lars@metafoo.de>
To: Anatol Pomozov <anatol.pomozov@gmail.com>, alsa-devel@alsa-project.org
Cc: kwestfie@codeaurora.org, broonie@kernel.org
Subject: Re: [PATCH 2/3] ASoC: max98357a: Specify digital input as a dapm widget
Date: Sun, 12 Jul 2015 12:33:30 +0200 [thread overview]
Message-ID: <55A2427A.30501@metafoo.de> (raw)
In-Reply-To: <1436684202-16461-2-git-send-email-anatol.pomozov@gmail.com>
On 07/12/2015 08:56 AM, Anatol Pomozov wrote:
> Spec does not say anything about DAC called SDMode.
> Create a dapm path that consists of path from I2S input to Speaker output.
>
> Signed-off-by: Anatol Pomozov <anatol.pomozov@gmail.com>
> ---
> sound/soc/codecs/max98357a.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/max98357a.c b/sound/soc/codecs/max98357a.c
> index 6d4246a..0d87d35 100644
> --- a/sound/soc/codecs/max98357a.c
> +++ b/sound/soc/codecs/max98357a.c
> @@ -51,12 +51,12 @@ static int max98357a_daiops_trigger(struct snd_pcm_substream *substream,
> }
>
> static const struct snd_soc_dapm_widget max98357a_dapm_widgets[] = {
> - SND_SOC_DAPM_DAC("SDMode", NULL, SND_SOC_NOPM, 0, 0),
> + SND_SOC_DAPM_AIF_IN("AIFRX", "HiFi Playback", 0, SND_SOC_NOPM, 0, 0),
> SND_SOC_DAPM_OUTPUT("Speaker"),
> };
>
> static const struct snd_soc_dapm_route max98357a_dapm_routes[] = {
> - {"Speaker", NULL, "SDMode"},
> + {"Speaker", NULL, "AIFRX"},
ASoC automatically creates a widget for the playback stream. You can connect
that directly here without the need for the AIF_IN widget. E.g.:
{ "Speaker", NULL, "HiFi Playback" },
> };
>
> static int max98357a_codec_probe(struct snd_soc_codec *codec)
>
next prev parent reply other threads:[~2015-07-12 10:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-12 6:56 [PATCH 1/3] ASoC: max98357a: Make 'sdmode-gpios' dts property optional Anatol Pomozov
2015-07-12 6:56 ` [PATCH 2/3] ASoC: max98357a: Specify digital input as a dapm widget Anatol Pomozov
2015-07-12 10:33 ` Lars-Peter Clausen [this message]
2015-07-12 15:15 ` Anatol Pomozov
2015-07-12 6:56 ` [PATCH 3/3] ASoC: max98357a: Do not print error message on gpio get Anatol Pomozov
2015-07-12 10:31 ` [PATCH 1/3] ASoC: max98357a: Make 'sdmode-gpios' dts property optional Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A2427A.30501@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=anatol.pomozov@gmail.com \
--cc=broonie@kernel.org \
--cc=kwestfie@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox