Re: [PATCH 2/6] ASoC: lpass-ipq806x: Staticise local symbols

[Srinivas Kandagatla <srinivas.kandagatla@linaro.org>]

On 27/07/15 09:56, Lars-Peter Clausen wrote:
> ipq806x_data is not used outside this file, so it can be static.
> Fixes the following sparse warning:
>
> 	sound/soc/qcom/lpass-ipq806x.c:76:22: warning: symbol 'ipq806x_data'
> 		was not declared. Should it be static?
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
>   sound/soc/qcom/lpass-ipq806x.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/qcom/lpass-ipq806x.c b/sound/soc/qcom/lpass-ipq806x.c
> index 7356d3a..7a41679 100644
> --- a/sound/soc/qcom/lpass-ipq806x.c
> +++ b/sound/soc/qcom/lpass-ipq806x.c
> @@ -73,7 +73,7 @@ static int ipq806x_lpass_free_dma_channel(struct lpass_data *drvdata, int chan)
>   	return 0;
>   }
>
> -struct lpass_variant ipq806x_data = {
> +static struct lpass_variant ipq806x_data = {
>   	.i2sctrl_reg_base	= 0x0010,
>   	.i2sctrl_reg_stride	= 0x04,
>   	.i2s_ports		= 5,
>
Thanks Lars for the patch, Looks good to me.

Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

--srini