Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver

From: Yakir Yang <ykk@rock-chips.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
	alsa-devel <alsa-devel@alsa-project.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Doug Anderson <dianders@chromium.org>,
	linux-rockchip@lists.infradead.org,
	Mark Brown <broonie@kernel.org>,
	Andy Yan <andy.yan@rock-chips.com>,
	Jaroslav Kysela <perex@perex.cz>, Paul Bolle <pebolle@tiscali.nl>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver
Date: Sun, 9 Aug 2015 14:17:03 +0800	[thread overview]
Message-ID: <55C6F05F.1030003@rock-chips.com> (raw)
In-Reply-To: <20150808153540.GL7557@n2100.arm.linux.org.uk>

[-- Attachment #1.1: Type: text/plain, Size: 1266 bytes --]

Hi Russell,

在 2015/8/8 23:35, Russell King - ARM Linux 写道:
> On Sat, Jun 20, 2015 at 12:28:15AM +0800, Yakir Yang wrote:
>> Add ALSA based HDMI I2S audio driver for dw_hdmi. Sound card
>> driver could connect to this codec through the codec dai name
>> "dw-hdmi-i2s-audio".
> I'm applying this patch to my tree with some changes.  I haven't seen
> anyone ack it, nor review it any further.  I'm hoping someone can ack
> this patch with the following changes below - I'll be posting it as
> part of my dw-hdmi devel updates later today.
Aha, wow !!!
I'm so happy now :-D, many thanks for your improved and applay.

- Yakir

>> +	ret = request_irq(dw->data.irq, snd_dw_hdmi_irq, IRQF_SHARED,
>> +			  "dw-dw-audio", dw);
> 			  DRIVER_NAME, dw);
>
>> +MODULE_AUTHOR("Yakir Yang <ykk@rock-chips.com>");
>> +MODULE_DESCRIPTION("DW dw Audio ASoC Interface");
> Fixing this to be "Synopsis DesignWare HDMI I2S ASoC interface".
>
>> +MODULE_LICENSE("GPL v2");
>> +MODULE_ALIAS(PLATFORM_MODULE_PREFIX DRIVER_NAME);
> Replacing PLATFORM_MODULE_PREFIX with the "platform:" string.
>
>> +	if (hdmi_readb(hdmi, HDMI_CONFIG1_ID) & HDMI_CONFIG1_AHB) {
>>   		pdevinfo.name = "dw-hdmi-ahb-audio";
> Fixing this to be "dw-hdmi-i2s-audio".
>

[-- Attachment #1.2: Type: text/html, Size: 2916 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel