From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Sakamoto Subject: Re: [PATCH 0/2] ALSA: fireworks/firewire-lib: add support for recent firmware quirk Date: Tue, 11 Aug 2015 07:44:03 +0900 Message-ID: <55C92933.50207@sakamocchi.jp> References: <1438734065-5204-1-git-send-email-o-takashi@sakamocchi.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp303.phy.lolipop.jp (smtp303.phy.lolipop.jp [210.157.22.87]) by alsa0.perex.cz (Postfix) with ESMTP id 61181260420 for ; Tue, 11 Aug 2015 00:44:10 +0200 (CEST) In-Reply-To: <1438734065-5204-1-git-send-email-o-takashi@sakamocchi.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: clemens@ladisch.de, tiwai@suse.de Cc: alsa-devel@alsa-project.org, ffado-devel@lists.sf.net List-Id: alsa-devel@alsa-project.org Hi, On Aug 5 2015 09:21, Takashi Sakamoto wrote: > Some users have reported current ALSA Fireworks driver stops packet > streaming due to detecting discontinuity. > > [alsa-devel] ALSA snd-fireworks Echo AudioFire 2 > http://mailman.alsa-project.org/pipermail/alsa-devel/2014-August/080379.html > > [alsa-devel] AudioFire4 quirk > http://mailman.alsa-project.org/pipermail/alsa-devel/2015-July/095697.html > > Linux 3.16 or later have this issue. > > As long as I investigate, this issue depends on firmware version installed > in these devices. While, it's not clear that which version of firmwares for > which model has this quirk. At least, firmware version 5.7.0, 5.7.3 and > 5.8.0 for AudioFire2/AudioFire4/AudioFirePre8 have this quirk. > > This patchset applies a solution for this issue, with my assumption that > 'the same firmware binary has the same quirk'. These models, AudioFire8 > (since Jul 2009) and Gibson Robot Interface Pack (RIP) series uses the > same firmware binary in driver package. > > If possible, the second patch should be applied to all of stable kernels. > > This patchset updates my previous RFC: > [alsa-devel] [RFC][PATCH 0/2] ALSA: fireworks/firewire-lib: add support for recent firmware quirk > http://mailman.alsa-project.org/pipermail/alsa-devel/2015-August/095849.html > > Takashi Sakamoto (2): > Revert "ALSA: fireworks: add support for AudioFire2 quirk" > ALSA: fireworks/firewire-lib: add support for recent firmware quirk > > sound/firewire/amdtp.c | 5 +++-- > sound/firewire/amdtp.h | 2 ++ > sound/firewire/fireworks/fireworks.c | 10 ++++++++-- > sound/firewire/fireworks/fireworks.h | 2 +- > sound/firewire/fireworks/fireworks_stream.c | 12 +++++++++--- > 5 files changed, 23 insertions(+), 8 deletions(-) Thanks for applying them. (And sorry to be late for reply because I got a short summer vacation.) Currently I'm preparing for the next patchset (Digi00x and TASCAM drivers). As a quick glance, for-next branch in sound.git doesn't still includes these two patches. In this case, which branch should my work reabases to? Regards Takashi Sakamoto