From mboxrd@z Thu Jan 1 00:00:00 1970 From: Valentin Corfu Subject: Re: [PATCH] jack: Fixing a small memory leak Date: Tue, 11 Aug 2015 10:43:23 +0300 Message-ID: <55C9A79B.9030508@gmail.com> References: <1439275034-577-1-git-send-email-corfuvalentin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by alsa0.perex.cz (Postfix) with ESMTP id C780E2604B3 for ; Tue, 11 Aug 2015 09:45:00 +0200 (CEST) Received: by wicja10 with SMTP id ja10so64433774wic.1 for ; Tue, 11 Aug 2015 00:45:00 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org I also thank you, for your implication. Have a nice day, Valentin Corfu On 11.08.2015 10:39, Takashi Iwai wrote: > On Tue, 11 Aug 2015 08:37:14 +0200, > Valentin Corfu wrote: >> A small memory leak can be observed when using alsa-plugins (jack). >> Check the following valgrind log: >> ... >> ==1034== 8 bytes in 1 blocks are definitely lost in loss record 7 of 108 >> ==1034== at 0x4027E5A: calloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so) >> ==1034== by 0x4035102: snd_pcm_jack_prepare (in /usr/lib/alsa-lib/libasound_module_pcm_jack.so) >> ==1034== by 0x40D07AB: snd_pcm_ioplug_prepare (pcm_ioplug.c:145) >> ==1034== by 0x4084961: snd_pcm_prepare (pcm.c:1052) >> ==1034== by 0x409DDB4: snd_pcm_plugin_prepare (pcm_plugin.c:162) >> ==1034== by 0x4084961: snd_pcm_prepare (pcm.c:1052) >> ==1034== by 0x409DDB4: snd_pcm_plugin_prepare (pcm_plugin.c:162) >> ==1034== by 0x4084961: snd_pcm_prepare (pcm.c:1052) >> ==1034== by 0x4084A1D: snd_pcm_hw_params (pcm.c:838) >> ==1034== by 0x4090013: snd_pcm_set_params (pcm.c:8053) >> ==1034== by 0x80486EB: main (in /root/pcm_min_ok) >> ... >> ==1034== LEAK SUMMARY: >> ==1034== definitely lost: 8 bytes in 1 blocks >> ==1034== indirectly lost: 0 bytes in 0 blocks >> ==1034== possibly lost: 31,311 bytes in 1,630 blocks >> ==1034== still reachable: 5,619 bytes in 24 blocks >> ==1034== suppressed: 0 bytes in 0 blocks >> ... >> >> Signed-off-by: Valentin Corfu > Applied, thanks. > > > Takashi > >> --- >> jack/pcm_jack.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/jack/pcm_jack.c b/jack/pcm_jack.c >> index 568ec43..de9c46e 100644 >> --- a/jack/pcm_jack.c >> +++ b/jack/pcm_jack.c >> @@ -103,6 +103,7 @@ static void snd_pcm_jack_free(snd_pcm_jack_t *jack) >> if (jack->io.poll_fd >= 0) >> close(jack->io.poll_fd); >> free(jack->areas); >> + free(jack->ports); >> free(jack); >> } >> } >> -- >> 1.9.1 >> >> _______________________________________________ >> Alsa-devel mailing list >> Alsa-devel@alsa-project.org >> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >>