From: Lars-Peter Clausen <lars@metafoo.de>
To: Ricard Wanderlof <ricard.wanderlof@axis.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: SSM2518 Device Tree support ?
Date: Thu, 13 Aug 2015 14:21:52 +0200 [thread overview]
Message-ID: <55CC8BE0.4000406@metafoo.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1508131400010.27635@lnxricardw1.se.axis.com>
On 08/13/2015 02:12 PM, Ricard Wanderlof wrote:
>
> We needed DT support in the SSM2518 codec driver, and I noticed that there
> is already a set of bindings specified in Documentation/devicetree,
> however, there doesn't seem to be any DT support in the driver itself. I
> don't know if this is the result of a missing commit ?
There is DT support in the driver. E.g. see the of_get_gpio() call.
What's not in the driver is a explicit of match table. It will work without
since the I2C subsystem supports matching based on the I2C ID table. But,
yes, it is better to add a explicit OF table to indicate that this works.
>
> Documentation/devicetree/bindings/sound/ssm2518.c seems to have been added
> in May 2013.
>
> I've added rudimentary support for at least the compatible property so
> that the driver can be used in a system with DT configuration (sent as a
> separate email).
next prev parent reply other threads:[~2015-08-13 12:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 12:12 SSM2518 Device Tree support ? Ricard Wanderlof
2015-08-13 12:21 ` Lars-Peter Clausen [this message]
2015-09-01 7:06 ` Ricard Wanderlof
2015-09-01 7:51 ` Lars-Peter Clausen
2015-09-01 12:39 ` Ricard Wanderlof
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CC8BE0.4000406@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=ricard.wanderlof@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox