Re: [PATCH RFC v3 3/7] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

Mark Brown
2015-08-17T18:41:08Z

[-- Attachment #1.1: Type: text/plain, Size: 947 bytes --]

On Mon, Aug 17, 2015 at 10:07:55AM +0300, Jyri Sarha wrote:
> On 08/14/15 19:18, Mark Brown wrote:
> >On Fri, Aug 14, 2015 at 12:30:41PM +0300, Jyri Sarha wrote:

> >>+ /* Called when ASoC starts an audio stream setup. The call
> >>+ * provides an audio abort callback for stoping an ongoing
> >>+ * stream if the HDMI audio becomes unavailable.
> >>+ * Optional */
> >>+ int (*audio_startup)(struct device *dev,
> >>+ void (*abort_cb)(struct device *dev));

> >I'm a bit confused about what is going to use abort_cb() and why they
> >wouldn't just call shutdown instead?

> audio_shutdown() is for ASoC side to tell video side that audio playback has
> stopped.

> The abort_cb() is for video side to inform ASoC that current audio stream
> can not continue anymore and it should be aborted. The similar mechanism is
> currently in use in sound/soc/omap/omap-hdmi-audio.c.

Someone reading the code needs to be able to understand this.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]