From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jyri Sarha Subject: Re: [PATCH RFC v3 3/7] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders Date: Mon, 17 Aug 2015 22:22:52 +0300 Message-ID: <55D2348C.5060103@ti.com> References: <20150814161820.GU10748@sirena.org.uk> <55D1884B.6050800@ti.com> <20150817184102.GW10748@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) by alsa0.perex.cz (Postfix) with ESMTP id 6231E260420 for ; Mon, 17 Aug 2015 21:23:00 +0200 (CEST) In-Reply-To: <20150817184102.GW10748@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, peter.ujfalusi@ti.com, moinejf@free.fr, airlied@linux.ie, dri-devel@lists.freedesktop.org, liam.r.girdwood@linux.intel.com, tony@atomide.com, tomi.valkeinen@ti.com, bcousson@baylibre.com, rmk+kernel@arm.linux.org.uk, linux-omap@vger.kernel.org List-Id: alsa-devel@alsa-project.org On 08/17/15 21:41, Mark Brown wrote: > On Mon, Aug 17, 2015 at 10:07:55AM +0300, Jyri Sarha wrote: >> On 08/14/15 19:18, Mark Brown wrote: >>> On Fri, Aug 14, 2015 at 12:30:41PM +0300, Jyri Sarha wrote: > >>>> + /* Called when ASoC starts an audio stream setup. The call >>>> + * provides an audio abort callback for stoping an ongoing >>>> + * stream if the HDMI audio becomes unavailable. >>>> + * Optional */ >>>> + int (*audio_startup)(struct device *dev, >>>> + void (*abort_cb)(struct device *dev)); > >>> I'm a bit confused about what is going to use abort_cb() and why they >>> wouldn't just call shutdown instead? > >> audio_shutdown() is for ASoC side to tell video side that audio playback has >> stopped. > >> The abort_cb() is for video side to inform ASoC that current audio stream >> can not continue anymore and it should be aborted. The similar mechanism is >> currently in use in sound/soc/omap/omap-hdmi-audio.c. > > Someone reading the code needs to be able to understand this. > Ok, I'll improve the comment above. Thanks, Jyri