From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wu, Songjun" Subject: Re: [alsa-devel] [PATCH] ASoC: atmel-classd: fix odd_ptr_err.cocci warnings Date: Tue, 29 Sep 2015 09:42:14 +0800 Message-ID: <5609EC76.1070109@atmel.com> References: <201509281735.7lYs3Huz%fengguang.wu@intel.com> <20150928091029.GA23312@roam> <874miekcnd.fsf@dell.be.48ers.dk> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <874miekcnd.fsf@dell.be.48ers.dk> Sender: linux-kernel-owner@vger.kernel.org To: Peter Korsgaard , kbuild test robot Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , nicolas.ferre@atmel.com, Liam Girdwood , broonie@kernel.org, kbuild-all@01.org, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org On 9/28/2015 19:26, Peter Korsgaard wrote: >>>>>> "kbuild" == kbuild test robot writes: > > > sound/soc/atmel/atmel-classd.c:578:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 579 > > PTR_ERR should access the value just tested by IS_ERR > > > Semantic patch information: > > There can be false positives in the patch case, where it is the call > > IS_ERR that is wrong. > > > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci > > > CC: Songjun Wu > > Signed-off-by: Fengguang Wu > > --- > > > atmel-classd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > --- a/sound/soc/atmel/atmel-classd.c > > +++ b/sound/soc/atmel/atmel-classd.c > > @@ -576,7 +576,7 @@ static int atmel_classd_probe(struct pla > > dd-> gclk = devm_clk_get(dev, "gclk"); > > if (IS_ERR(dd->aclk)) { > > - ret = PTR_ERR(dd->gclk); > > + ret = PTR_ERR(dd->aclk); > > It looks like it is the other way around. It should test > IS_ERR(dd->gclk) instead. > Thank you, you are right. It should test IS_ERR(dd->gclk) instead.